public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Larry Finger <Larry.Finger@lwfinger•net>
Cc: linville@tuxdriver•com, linux-wireless@vger•kernel.org,
	netdev@vger•kernel.org
Subject: Re: [PATCH 5/8 V2] [PATCH 5/7: rtlwifi: Fix smatch warning in pci.c
Date: Mon, 16 Sep 2013 23:11:28 +0400	[thread overview]
Message-ID: <523757E0.6010903@cogentembedded.com> (raw)
In-Reply-To: <5237562D.4080509@cogentembedded.com>

On 09/16/2013 11:04 PM, Sergei Shtylyov wrote:

>> Smatch reports the following:
>>    CHECK   drivers/net/wireless/rtlwifi/pci.c
>> drivers/net/wireless/rtlwifi/pci.c:739 _rtl_pci_rx_interrupt() warn:
>> assigning (-98) to unsigned variable 'stats.noise'

>> This variable is not used and is removed.

>     It is not a variable but a structure field initializer you're removing.

    Meant to also write that your subject is spoiled but forgot. :-)

WBR, Sergei

  reply	other threads:[~2013-09-16 19:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16 18:55 [PATCH 0/8i V2] rtlwifi: Patches to fix problems shown by smatch Larry Finger
2013-09-16 18:55 ` [PATCH 1/8 V2] rtlwifi: rtl8192du: Fix smatch errors in /rtl8192de/dm.c Larry Finger
2013-09-16 18:55 ` [PATCH 3/8 V2] rtlwifi: rtl8192cu: Fix smatch warning in rtl8192cu/trx.c Larry Finger
     [not found]   ` <1379357722-17687-4-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-09-16 19:05     ` Sergei Shtylyov
2013-09-16 18:55 ` [PATCH 7/8 V2] rtlwifi: rtl8188ee: Fix smatch warning in rtl8188ee/hw.c Larry Finger
     [not found] ` <1379357722-17687-1-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-09-16 18:55   ` [PATCH 2/8 V2] rtlwifi: rtl8192de: Fix smatch warnings in rtl8192de/hw.c Larry Finger
     [not found]     ` <1379357722-17687-3-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-09-16 21:44       ` Kalle Valo
2013-09-16 18:55   ` [PATCH 4/8 V2] rtlwifi: rtl8192_common: Fix smatch errors and warnings in rtl8192c/dm_common.c Larry Finger
     [not found]     ` <1379357722-17687-5-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-09-16 19:02       ` Sergei Shtylyov
2013-09-16 19:07         ` Larry Finger
2013-09-16 19:10           ` Sergei Shtylyov
2013-09-16 18:55   ` [PATCH 5/8 V2] [PATCH 5/7: rtlwifi: Fix smatch warning in pci.c Larry Finger
     [not found]     ` <1379357722-17687-6-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-09-16 19:04       ` Sergei Shtylyov
2013-09-16 19:11         ` Sergei Shtylyov [this message]
2013-09-16 18:55   ` [PATCH 6/8 V2] rtlwifi: Fix smatch warnings in usb.c Larry Finger
     [not found]     ` <1379357722-17687-7-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2013-09-16 19:07       ` Sergei Shtylyov
2013-09-16 18:55   ` [PATCH 8/8 V2] rtlwifi: Remove variable 'noise' from rtl_stats struct Larry Finger
2013-09-17  8:48     ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523757E0.6010903@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded$(echo .)com \
    --cc=Larry.Finger@lwfinger$(echo .)net \
    --cc=linux-wireless@vger$(echo .)kernel.org \
    --cc=linville@tuxdriver$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox