Subject: Re: [PATCH ] ipv6: handle the update of the NDISC_REDIRECT error code in icmpv6_err_convert

From: Duan Jiong <[email-masked]>
Date: Thu, 19 Sep 2013 13:24:04 +0800

于 2013/9/19 0:36, David Miller 写道:
> From: Duan Jiong <[email-masked]>
> Date: Wed, 18 Sep 2013 20:04:48 +0800
>
>> From: Duan Jiong <[email-masked]>
>>
>> when dealing with redirect message in udpv6_err() and
>> rawv6_err() the err shoud be assigned to 0, not EPROTO.
>>
>> Signed-off-by: Duan Jiong <[email-masked]>
> No, you should fix this the same way you handled DCCP, but skipping
> the whole socket error setting path for NDISC_REDIRECT.

Your meaning is that we should return directly after calling
ip6_sk_redirect(), is that it?

Thanks,
   Duan

> Clearing the socket error to zero is not correct, it means you will
> lose any existing error setting.