Subject: Re: [net-next] Fix hardcoded ni65 interrupt name to use system device value

From: Sergei Shtylyov <[email-masked]>
Date: Sat, 21 Sep 2013 23:48:33 +0400

Hello.

On 09/21/2013 11:32 PM, Mark Repka wrote:

> The ni65 interrupt handler was using the hard-coded name which would make it difficult to tell where the interrupt came from. Changed to use the device name that made the interrupt.

    Please wrap your changelog lines at 80 columns (preferably even less).

> Signed-off-by: Mark Repka <[email-masked]>
> ---
>   drivers/net/ethernet/amd/ni65.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/amd/ni65.c b/drivers/net/ethernet/amd/ni65.c
> index 1cf33ad..00cb6db 100644
> --- a/drivers/net/ethernet/amd/ni65.c
> +++ b/drivers/net/ethernet/amd/ni65.c
> @@ -295,7 +295,7 @@ static int ni65_open(struct net_device *dev)
>   {
>   	struct priv *p = dev->ml_priv;
>   	int irqval = request_irq(dev->irq, ni65_interrupt,0,
> -                        cards[p->cardno].cardname,dev);
> +                       dev->name,dev);

    Don't indent with all spaces, use tabs at the start of line. And start the 
line under 'dev->irq' please.

WBR, Sergei