Subject: Re: [PATCH] net: flow_dissector: fix thoff for IPPROTO_AH

From: Nikolay Aleksandrov <[email-masked]>
Date: Thu, 26 Sep 2013 18:03:12 +0200

On 09/26/2013 06:05 PM, Eric Dumazet wrote:
> On Thu, 2013-09-26 at 17:48 +0200, Nikolay Aleksandrov wrote:
> 
>>
>> 1 question about my current patchset, can I leave it to get reviewed and if
>> applied to post a follow-up for net-next that fixes the issue, or would you
>> prefer a v4 that integrates the fix ?
> 
> I think your 1/3 patch only has to pass nhoff as value instead of
> reference.
> 
> +__be32 skb_flow_get_ports(const struct sk_buff *skb, int thoff, u8 ip_proto)
> +{
> +       int poff = proto_ports_offset(ip_proto);
> +
> +       if (poff >= 0) {
> +               __be32 *ports, _ports;
> +
> +               ports = skb_header_pointer(skb, thoff + poff,
> +					   sizeof(_ports), &_ports);
> +               if (ports)
> +                       return *ports;
> +       }
> +
> +       return 0;
> +}
> 
> 
Yeah, exactly but 2/3 will need a change as well because it uses the function.
I'll just re-post a v4 with the change in a bit.

Thanks