Subject: Re: [PATCH net-next] qdisc: basic classifier - remove unnecessary initialization

From: Jamal Hadi Salim <[email-masked]>
Date: Sun, 29 Sep 2013 07:28:17 -0400

On 13-09-26 08:42 PM, Stephen Hemminger wrote:
> err is set once, then first code resets it.
>    err = tcf_exts_validate(...)
>
> Signed-off-by: Stephen Hemminger <[email-masked]>
>
>
> --- a/net/sched/cls_basic.c	2013-08-10 10:36:11.657498301 -0700
> +++ b/net/sched/cls_basic.c	2013-09-05 18:05:14.718200833 -0700
> @@ -137,7 +137,7 @@ static int basic_set_parms(struct net *n
>   			   struct nlattr **tb,
>   			   struct nlattr *est)
>   {
> -	int err = -EINVAL;
> +	int err;
>   	struct tcf_exts e;
>   	struct tcf_ematch_tree t;
>

Acked-by: Jamal Hadi Salim <[email-masked]>

cheers,
jamal