From: Ivan Vecera <ivecera@redhat•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Sathya Perla <sathya.perla@emulex•com>, netdev@vger•kernel.org
Subject: Re: [PATCH 2/2] be2net: drop non-tso frames longer than mtu
Date: Tue, 15 Oct 2013 16:30:35 +0200 [thread overview]
Message-ID: <525D518B.5010901@redhat.com> (raw)
In-Reply-To: <1381844840.2045.37.camel@edumazet-glaptop.roam.corp.google.com>
On 10/15/2013 03:47 PM, Eric Dumazet wrote:
> On Tue, 2013-10-15 at 17:26 +0530, Sathya Perla wrote:
>> From: Vasundhara Volam <vasundhara.volam@emulex•com>
>>
>> Pktgen can generate non-TSO frames of arbitrary length disregarding
>> the MTU value of the physical interface. Drop such frames in the driver
>> instead of sending them to HW as it cannot handle such frames.
>>
>> Signed-off-by: Vasundhara Volam <vasundhara.volam@emulex•com>
>> Signed-off-by: Sathya Perla <sathya.perla@emulex•com>
>> ---
>> drivers/net/ethernet/emulex/benet/be_main.c | 9 +++++++--
>> 1 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
>> index 2c38cc4..76057b8 100644
>> --- a/drivers/net/ethernet/emulex/benet/be_main.c
>> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
>> @@ -855,6 +855,13 @@ static struct sk_buff *be_xmit_workarounds(struct be_adapter *adapter,
>> unsigned int eth_hdr_len;
>> struct iphdr *ip;
>>
>> + /* Don't allow non-TSO packets longer than MTU */
>> + eth_hdr_len = (ntohs(skb->protocol) == ETH_P_8021Q) ?
>> + VLAN_ETH_HLEN : ETH_HLEN;
>> + if (!skb_is_gso(skb) &&
>> + (skb->len - eth_hdr_len) > adapter->netdev->mtu)
>> + goto tx_drop;
>> +
>
> When you say 'cannot handle them', is it some kind of nasty thing like
> hang / crash ?
AFAIK, the firmware in the card becomes unresponsive and reboot is
needed to make the NIC working.
Ivan
next prev parent reply other threads:[~2013-10-15 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 11:56 [PATCH 1/2] be2net: pass if_id for v1 and V2 versions of TX_CREATE cmd Sathya Perla
2013-10-15 11:56 ` [PATCH 2/2] be2net: drop non-tso frames longer than mtu Sathya Perla
2013-10-15 13:45 ` Sergei Shtylyov
2013-10-15 13:47 ` Eric Dumazet
2013-10-15 14:30 ` Ivan Vecera [this message]
2013-10-16 12:08 ` Sathya Perla
2013-10-16 13:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525D518B.5010901@redhat.com \
--to=ivecera@redhat$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sathya.perla@emulex$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox