From: Rhyland Klein <rklein@nvidia•com>
To: Heikki Krogerus <heikki.krogerus@linux•intel.com>
Cc: "John W. Linville" <linville@tuxdriver•com>,
Johannes Berg <johannes@sipsolutions•net>,
"Rafael J. Wysocki" <rjw@rjwysocki•net>,
"linux-acpi@vger•kernel.org" <linux-acpi@vger•kernel.org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH 0/5] rfkill-gpio: ACPI support
Date: Wed, 16 Oct 2013 12:13:36 -0400 [thread overview]
Message-ID: <525EBB30.5030602@nvidia.com> (raw)
In-Reply-To: <1381920823-15403-1-git-send-email-heikki.krogerus@linux.intel.com>
On 10/16/2013 6:53 AM, Heikki Krogerus wrote:
> Hi,
>
> The first patches prepare the driver for the support. The last patch
> can then add the support quite easily. With these patches, adding DT
> support later will be quite straight forward if someone needs it.
>
>
> Heikki Krogerus (5):
> net: rfkill: gpio: convert to resource managed allocation
> net: rfkill: gpio: clean up clock handling
> net: rfkill: gpio: spinlock-safe GPIO access
> net: rfkill: gpio: prepare for DT and ACPI support
> net: rfkill: gpio: add ACPI support
>
> net/rfkill/Kconfig | 2 +-
> net/rfkill/rfkill-gpio.c | 211 ++++++++++++++++++++++-------------------------
> 2 files changed, 99 insertions(+), 114 deletions(-)
>
Strictly speaking, duplicating the pdata fields into the
rfkill_gpio_data structure isn't really necessary. Many drivers simply
have the dt parsing or in this case ACPI parsing generate a
platform_data structure which would then be saved in the
rfkill_gpio_data structure.
In this case, since it is only a few fields, I am not too worried and I
am fine either way.
Acked-by: Rhyland Klein <rklein@nvidia•com>
--
nvpublic
next prev parent reply other threads:[~2013-10-16 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 10:53 [PATCH 0/5] rfkill-gpio: ACPI support Heikki Krogerus
2013-10-16 10:53 ` [PATCH 1/5] net: rfkill: gpio: convert to resource managed allocation Heikki Krogerus
2013-10-16 10:53 ` [PATCH 2/5] net: rfkill: gpio: clean up clock handling Heikki Krogerus
2013-10-16 10:53 ` [PATCH 4/5] net: rfkill: gpio: prepare for DT and ACPI support Heikki Krogerus
[not found] ` <1381920823-15403-1-git-send-email-heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-10-16 10:53 ` [PATCH 3/5] net: rfkill: gpio: spinlock-safe GPIO access Heikki Krogerus
2013-10-16 10:53 ` [PATCH 5/5] net: rfkill: gpio: add ACPI support Heikki Krogerus
2013-10-16 20:55 ` Rafael J. Wysocki
2013-10-17 7:44 ` Mika Westerberg
2013-10-17 11:48 ` Rafael J. Wysocki
2013-10-16 16:13 ` Rhyland Klein [this message]
2013-10-17 14:26 ` [PATCH 0/5] rfkill-gpio: " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525EBB30.5030602@nvidia.com \
--to=rklein@nvidia$(echo .)com \
--cc=heikki.krogerus@linux$(echo .)intel.com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rjw@rjwysocki$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox