public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu•com>
To: vyasevic@redhat•com, Stephen Hemminger <stephen@networkplumber•org>
Cc: Stephen Hemminger <shemminger@vyatta•com>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [RFC] bridge and friends: reduce TheLinuxWay(tm)
Date: Wed, 16 Oct 2013 13:49:34 -0400	[thread overview]
Message-ID: <525ED1AE.7050101@mojatatu.com> (raw)
In-Reply-To: <525EC8AF.6000902@redhat.com>

On 10/16/13 13:11, Vlad Yasevich wrote:
> On 10/16/2013 09:54 AM, Jamal Hadi Salim wrote:
>
>
> This was to display or filter out virtual function data.
>

Stephen explained - and it seems to make sense (working around
netlink weaknesses). It could be made more generic.


> I probably doesn't need to use this as we want the bridge data, not the
> VF data stored as part of PF interface.
>

I think we need some filtering in the kernel. As it stands today,
unfortunately you get everything ;-> I was suprised at the amount of
data i get from the kernel these days when i ask for a simple netdev
info (I think no less than 1K per netdev; everything from /proc entries
from some bread crumbs i dont see any use for.

>> - get attributes for all bridge ports for bridge br-blah (not there)
>> you could also use the ifindex of br-blah here instead
>
> This would be usefull.
>

Its a usability improvement.
We still have the ifi->ifindex available. It could be used to signal
which bridge device's ports i want.
But then i get _all_ the ports for that bridge.

>
>
> You can already do this with:
>
>      ip link set dev ethX master brX
>

Yes, I know - it sucks from a usability pov.

cheers,
jamal

  reply	other threads:[~2013-10-16 17:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-14 21:32 [RFC] bridge and friends: reduce TheLinuxWay(tm) Jamal Hadi Salim
2013-10-14 21:41 ` Stephen Hemminger
2013-10-16 13:54   ` Jamal Hadi Salim
2013-10-16 14:05     ` Jamal Hadi Salim
2013-10-16 17:11     ` Vlad Yasevich
2013-10-16 17:49       ` Jamal Hadi Salim [this message]
2013-10-16 18:35         ` Eric Dumazet
2013-10-16 18:49           ` Stephen Hemminger
2013-10-16 18:50           ` Vlad Yasevich
2013-10-16 19:02             ` Jamal Hadi Salim
2013-10-16 20:19               ` Jamal Hadi Salim
2013-10-16 20:22                 ` Vlad Yasevich
2013-10-18 10:42                   ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525ED1AE.7050101@mojatatu.com \
    --to=jhs@mojatatu$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=shemminger@vyatta$(echo .)com \
    --cc=stephen@networkplumber$(echo .)org \
    --cc=vyasevic@redhat$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox