Subject: Re: [RFC] bridge and friends: reduce TheLinuxWay(tm)

From: Vlad Yasevich <[email-masked]>
Date: Wed, 16 Oct 2013 16:22:08 -0400

On 10/16/2013 04:19 PM, Jamal Hadi Salim wrote:
>
> And another little glitch, iflink specifies
>
>      [IFLA_AF_SPEC] = {
>          [AF_INET] = {
>              [IFLA_INET_CONF] = ...,
>          },
>          [AF_INET6] = {
>              [IFLA_INET6_FLAGS] = ...,
>              [IFLA_INET6_CONF] = ...,
>          }
>
> But then bridge hijacks it and specifies:
>    [IFLA_AF_SPEC] = {
>        [IFLA_BRIDGE_FLAGS]
>        [IFLA_BRIDGE_MODE]
>        [IFLA_BRIDGE_VLAN_INFO]
>    }
>
> Was that intended as:
>
>   [IFLA_AF_SPEC] = {
>     [AF_BRIDGE] = {
>         [IFLA_BRIDGE_FLAGS]
>         [IFLA_BRIDGE_MODE]
>         [IFLA_BRIDGE_VLAN_INFO]
>     }
>   }
>
> Now granted that bridging uses PF_BRIDGE as the family and iflink uses
> PF_UNSPEC - but i do think this one is polluting the namespace.
>

Yes, I know about that one.  BRIDGE_FLAGS started the polution and then 
we continued it with the other attributes....

-vlad

> cheers,
> jamal