public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger•net>
To: gregkh@linuxfoundation•org
Cc: devel@driverdev•osuosl.org, netdev <netdev@vger•kernel.org>,
	Larry Finger <Larry.Finger@lwfinger•net>
Subject: [PATCH 5/9 RESENT] staging: r8188eu: Fix sparse warnings in rtl8188e.cmd.c
Date: Fri, 18 Oct 2013 16:35:42 -0500	[thread overview]
Message-ID: <5261A9AE.8060103@lwfinger.net> (raw)
In-Reply-To: <1382129563-8496-1-git-send-email-Larry.Finger@lwfinger.net>

Sparse displays the following:

   CHECK   drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15:    expected unsigned short 
[usertype] *fctrl
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15:    got restricted __le16 
*<noident>
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:368:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:368:15:    expected unsigned short 
[usertype] *fctrl
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:368:15:    got restricted __le16 
*<noident>
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:403:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:403:15:    expected unsigned short 
[usertype] *fctrl
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:403:15:    got restricted __le16 
*<noident>
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15: warning: incorrect type in 
assignment (different base types)
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:    expected unsigned short 
[usertype] *fctrl
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:    got restricted __le16 
*<noident>

Signed-off-by: Larry Finger <Larry.Finger@lwfinger•net>
---
  drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
index 0b0c68c..8be2ad7 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
@@ -273,7 +273,7 @@ void rtl8188e_set_FwMediaStatus_cmd(struct adapter *adapt, 
__le16 mstatus_rpt)
  static void ConstructBeacon(struct adapter *adapt, u8 *pframe, u32 *pLength)
  {
  	struct rtw_ieee80211_hdr	*pwlanhdr;
-	u16 *fctrl;
+	__le16 *fctrl;
  	u32 rate_len, pktlen;
  	struct mlme_ext_priv *pmlmeext = &(adapt->mlmeextpriv);
  	struct mlme_ext_info	*pmlmeinfo = &(pmlmeext->mlmext_info);
@@ -360,7 +360,7 @@ static void ConstructPSPoll(struct adapter *adapt, u8 
*pframe, u32 *pLength)
  	struct rtw_ieee80211_hdr	*pwlanhdr;
  	struct mlme_ext_priv *pmlmeext = &(adapt->mlmeextpriv);
  	struct mlme_ext_info	*pmlmeinfo = &(pmlmeext->mlmext_info);
-	u16 *fctrl;
+	__le16 *fctrl;
   	pwlanhdr = (struct rtw_ieee80211_hdr *)pframe;
  @@ -391,7 +391,7 @@ static void ConstructNullFunctionData(struct adapter 
*adapt, u8 *pframe,
  	u8 bForcePowerSave)
  {
  	struct rtw_ieee80211_hdr	*pwlanhdr;
-	u16 *fctrl;
+	__le16 *fctrl;
  	u32 pktlen;
  	struct mlme_priv *pmlmepriv = &adapt->mlmepriv;
  	struct wlan_network		*cur_network = &pmlmepriv->cur_network;
@@ -450,7 +450,7 @@ static void ConstructNullFunctionData(struct adapter *adapt, 
u8 *pframe,
  static void ConstructProbeRsp(struct adapter *adapt, u8 *pframe, u32 *pLength, 
u8 *StaAddr, bool bHideSSID)
  {
  	struct rtw_ieee80211_hdr	*pwlanhdr;
-	u16 *fctrl;
+	__le16 *fctrl;
  	u8 *mac, *bssid;
  	u32 pktlen;
  	struct mlme_ext_priv *pmlmeext = &(adapt->mlmeextpriv);
-- 
1.8.4

  parent reply	other threads:[~2013-10-18 21:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1382129563-8496-1-git-send-email-Larry.Finger@lwfinger.net>
2013-10-18 21:32 ` [PATCH 1/9 RESENT] staging: r8188eu: Set device type to wlan Larry Finger
2013-10-18 21:58   ` Sergei Shtylyov
2013-10-18 21:33 ` [PATCH 2/9 RESENT] staging: r8188eu: Fix Sparse warnings in rtw_wlan_util Larry Finger
2013-10-18 22:05   ` Ben Hutchings
2013-10-18 21:34 ` [PATCH 3/9 RESENT] staging: r8188eu: Fix sparse warnings in ioctl_linux.c Larry Finger
2013-10-18 22:08   ` Ben Hutchings
2013-10-19  1:45     ` Larry Finger
2013-10-18 21:35 ` [PATCH 4/9 RESENT] staging: r8188eu: Fix sparse warnings in rtw_ieee80211.c Larry Finger
2013-10-18 21:35 ` Larry Finger [this message]
2013-10-18 21:36 ` [PATCH 6/9 RESENT] staging: r8188eu: Fix sparse warnings in rtw_mlme_ext.c Larry Finger
2013-10-18 21:37 ` [PATCH 7/9 RESENT] staging: r8188eu: Fix sparse warnings in rtl_p2p.c Larry Finger
2013-10-18 21:37 ` [PATCH 8/9 RESENT] staging: r8188eu: Fix sparse warnings in rtw_xmit.c Larry Finger
2013-10-18 21:38 ` [PATCH 9/9 RESENT] staging: r8188eu: Fix sparse warnings in rtw_br_ext.c Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5261A9AE.8060103@lwfinger.net \
    --to=larry.finger@lwfinger$(echo .)net \
    --cc=devel@driverdev$(echo .)osuosl.org \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox