From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Willem de Bruijn <willemb@google•com>,
netdev@vger•kernel.org, davem@davemloft•net
Subject: Re: [PATCH stable 3.11] sit: amend "allow to use rtnl ops on fb tunnel"
Date: Tue, 22 Oct 2013 17:43:49 +0200 [thread overview]
Message-ID: <52669D35.4040103@6wind.com> (raw)
In-Reply-To: <1382453958-32376-1-git-send-email-willemb@google.com>
Le 22/10/2013 16:59, Willem de Bruijn a écrit :
> Amend backport to 3.11.y of
>
> [ Upstream commit 205983c43700ac3a81e7625273a3fa83cd2759b5 ]
>
> The discussion thread in the upstream commit mentions that in
> backports to stable-* branches, the line
>
> - unregister_netdevice_queue(sitn->fb_tunnel_dev, &list);
>
> must be omitted if that branch does not have commit 5e6700b3bf98
> ("sit: add support of x-netns"). This line has correctly been omitted
> in the backport to 3.10, which indeed does not have that commit.
>
> It was also removed in the backport to 3.11.y, which does have that
> commit.
>
> This causes the following steps to hit a BUG at net/core/dev.c:5039:
>
> `modprobe sit; rmmod sit`
>
> The bug demonstrates that it causes a device to be unregistered twice.
> The simple fix is to apply the one line in the upstream commit that
> was dropped in the backport to 3.11 (3783100374653e2e7fbdf68c710f5).
> This brings the logic in line with upstream linux, net and net-next
> branches.
>
> Signed-off-by: Willem de Bruijn <willemb@google•com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
next prev parent reply other threads:[~2013-10-22 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 14:59 [PATCH stable 3.11] sit: amend "allow to use rtnl ops on fb tunnel" Willem de Bruijn
2013-10-22 15:43 ` Nicolas Dichtel [this message]
2013-10-22 15:56 ` Veaceslav Falico
2013-10-22 17:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52669D35.4040103@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox