Subject: Re: [PATCH net v3] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver

From: Ivan Vecera <[email-masked]>
Date: Thu, 24 Oct 2013 10:37:06 +0200

Hi Som,
see my inline comment below...

Ivan
On 10/23/2013 01:29 PM, Somnath Kotur wrote:
> On very old FW versions < 4.0, the mailbox command to set interrupts
> on the card succeeds even though it is not supported and should have
> failed, leading to a scenario where interrupts do not work.
> Hence warn users to upgrade to a suitable FW version to avoid seeing
> broken functionality.
>
> Signed-off-by: Somnath Kotur <[email-masked]>
> ---
> v3: Incorporated comments from Ben Hutchings, Joe Perches and Ivan Vercera
>
>   drivers/net/ethernet/emulex/benet/be.h      |    9 +++++++++
>   drivers/net/ethernet/emulex/benet/be_main.c |    6 ++++++
>   2 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
> index db02023..da9c04b 100644
> --- a/drivers/net/ethernet/emulex/benet/be.h
> +++ b/drivers/net/ethernet/emulex/benet/be.h
> @@ -696,6 +696,15 @@ static inline int qnq_async_evt_rcvd(struct be_adapter *adapter)
>   	return adapter->flags & BE_FLAGS_QNQ_ASYNC_EVT_RCVD;
>   }
>
> +static inline u32 fw_major_num(const char *fw_ver)
> +{
> +	int fw_major = 0;
> +
> +	sscanf(fw_ver, "%d.", &fw_major);
> +
> +	return fw_major;
> +}
> +
You changed fw_major as I mentioned in our private discussion but the 
return type should be also 'int' and not 'u32'.

>   extern void be_cq_notify(struct be_adapter *adapter, u16 qid, bool arm,
>   		u16 num_popped);
>   extern void be_link_status_update(struct be_adapter *adapter, u8 link_status);
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index 2c38cc4..53ed58b 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -3247,6 +3247,12 @@ static int be_setup(struct be_adapter *adapter)
>
>   	be_cmd_get_fw_ver(adapter, adapter->fw_ver, adapter->fw_on_flash);
>
> +	if (BE2_chip(adapter) && fw_major_num(adapter->fw_ver) < 4) {
> +		dev_err(dev, "Firmware on card is old(%s), IRQs may not work",
> +			adapter->fw_ver);
> +		dev_err(dev, "Please upgrade firmware to version >= 4.0\n");
> +	}
> +
>   	if (adapter->vlans_added)
>   		be_vid_config(adapter);
>
>