Subject: Re: [PATCH net-next] jazzsonic: printk() style fixes

From: Sergei Shtylyov <[email-masked]>
Date: Fri, 25 Oct 2013 01:50:34 +0400

Hello.

On 10/25/2013 01:39 AM, Tom D'Alba wrote:

> From: Tom D'Alba <[email-masked]>

> Fixed printk() format by adding correct KERN_ statuses.

> Reviewed-by: Nicholas Guthrie <[email-masked]>
> Reviewed-by: Sarah Williams <[email-masked]>
> Reviewed-by: Jason Lee <[email-masked]>
> Signed-off-by: Tom D'Alba <[email-masked]>
> ---
>   drivers/net/ethernet/natsemi/jazzsonic.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

> diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c
> index 79257f7..3a04d32 100644
> --- a/drivers/net/ethernet/natsemi/jazzsonic.c
> +++ b/drivers/net/ethernet/natsemi/jazzsonic.c
> @@ -135,7 +135,7 @@ static int sonic_probe1(struct net_device *dev)
>   	 */
>   	silicon_revision = SONIC_READ(SONIC_SR);
>   	if (sonic_debug > 1)
> -		printk("SONIC Silicon Revision = 0x%04x\n",silicon_revision);
> +	  printk(KERN_INFO "SONIC Silicon Revision = 0x%04x\n",silicon_revision);

    Please don't change the indentation.

> @@ -143,13 +143,13 @@ static int sonic_probe1(struct net_device *dev)
>   		i++;
>
>   	if (known_revisions[i] == 0xffff) {
> -		printk("SONIC ethernet controller not found (0x%4x)\n",
> +		printk(KERN_ERR "SONIC ethernet controller not found (0x%4x)\n",
>   		       silicon_revision);
>   		goto out;
>   	}
>
>   	if (sonic_debug  &&  version_printed++ == 0)
> -		printk(version);
> +	      printk(KERN_INFO version);

    Same here.

WBR, Sergei