Subject: Re: [PATCH v2] can: add Renesas R-Car CAN driver

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 06 Nov 2013 01:59:26 +0300

Hello.

On 11/03/2013 10:38 PM, Wolfgang Grandegger wrote:

>>>> Add support for the CAN controller found in Renesas R-Car SoCs.

>>>> Signed-off-by: Sergei Shtylyov <[email-masked]>

>> [...]

>>>> Index: linux-can-next/drivers/net/can/rcar_can.c
>>>> ===================================================================
>>>> --- /dev/null
>>>> +++ linux-can-next/drivers/net/can/rcar_can.c
>>>> @@ -0,0 +1,920 @@
>> [...]

>>>> +            rcar_can_writeb(priv, RCAR_CAN_ECSR, (u8)~ECSR_ADEF);

>>> Please avoid casts here and below.

>>     These casts help avoid compiler warnings.

> Well instead of using casts the declaration of ECSR_ADEF and otheres
> should be fixed. I think the problem is that BIT is declared as shown below:

>   #define BIT(nr)                 (1UL << (nr))

> Using BIT seems not appropriate here.

    Well, I thought it was designed to replace explicit (1 << (nr)) #define's. 
Hopefully those are good for you then...

> Wolfgang,

WBR, Sergei