Subject: Re: [PATCH net-next 1/3] net: move pskb_put() to core code

From: Mathias Krause <[email-masked]>
Date: Wed, 06 Nov 2013 10:01:11 +0100

On 05.11.2013 19:33, Ben Hutchings wrote:
> On Tue, 2013-11-05 at 14:54 +0100, Mathias Krause wrote:
>> This function has usage beside IPsec so move it to the core skbuff code.
>> While doing so, give it some documentation and change its return type to
>> 'unsigned char *' to be in line with skb_put().
> [...]
>> --- a/net/core/skbuff.c
>> +++ b/net/core/skbuff.c
>> @@ -1257,6 +1257,29 @@ free_skb:
>>  EXPORT_SYMBOL(skb_pad);
>>  
>>  /**
>> + *	pskb_put - add data to the tail of a potentially fragmented buffer
>> + *	@skb: start of the buffer to use
>> + *	@tail: tail fragment of the buffer to use
>> + *	@len: amount of data to add
>> + *
>> + *	This function extends the used data area of the potentially
>> + *	fragmented buffer. &tail must be the last fragment of &skb -- or
>> + *	&skb itself. If this would exceed the total buffer size the kernel
> 
> Keep using @ to refer to the parameters in this description.
> 
> Ben.

Thanks Ben. Looks like I looked at the wrong examples on how to do it.
Will fix those as well.

> 
>> + *	will panic. A pointer to the first byte of the extra data is
>> + *	returned.
>> + */
> [...]
>