From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Jiri Benc <jbenc@redhat•com>, netdev@vger•kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter•org>,
Petr Matousek <pmatouse@redhat•com>
Subject: Re: [PATCH net-next] nfnetlink: do not ack malformed messages
Date: Fri, 08 Nov 2013 02:03:20 +0300 [thread overview]
Message-ID: <527C1C38.40908@cogentembedded.com> (raw)
In-Reply-To: <fa44451df8aa56773b1b17cbbd86ced8b54eca5a.1383850681.git.jbenc@redhat.com>
Hello.
On 11/07/2013 09:59 PM, Jiri Benc wrote:
> Commit 0628b123c96d ("netfilter: nfnetlink: add batch support and use it
> from nf_tables") introduced a bug leading to various crashes in netlink_ack
> when netlink message with invalid nlmsg_len was sent by an unprivileged
> user.
> Signed-off-by: Jiri Benc <jbenc@redhat•com>
> ---
> net/netfilter/nfnetlink.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
> diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
> index 027f16a..046aa13 100644
> --- a/net/netfilter/nfnetlink.c
> +++ b/net/netfilter/nfnetlink.c
> @@ -363,13 +363,15 @@ static void nfnetlink_rcv(struct sk_buff *skb)
> struct net *net = sock_net(skb->sk);
> int msglen;
>
> - if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
> - return netlink_ack(skb, nlh, -EPERM);
> -
Hm, how it even compiled before your patch?
WBR, Sergei
next prev parent reply other threads:[~2013-11-07 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 18:59 [PATCH net-next] nfnetlink: do not ack malformed messages Jiri Benc
2013-11-07 23:03 ` Sergei Shtylyov [this message]
2013-11-10 1:46 ` Cong Wang
2013-11-08 20:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527C1C38.40908@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=jbenc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=pmatouse@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox