From: Jamal Hadi Salim <jhs@mojatatu•com>
To: David Miller <davem@davemloft•net>, tgraf@suug•ch
Cc: jbenc@redhat•com, netdev@vger•kernel.org, pablo@netfilter•org
Subject: Re: [PATCH net] netlink: fix netlink_ack with large messages
Date: Sat, 09 Nov 2013 08:43:51 -0500 [thread overview]
Message-ID: <527E3C17.1080508@mojatatu.com> (raw)
In-Reply-To: <20131109.000012.1393414533296613338.davem@davemloft.net>
On 11/09/13 00:00, David Miller wrote:
> The user has the message, they gave it to us in the sendmsg()
> we are responding to. We absolutely do not need to give it
> to them again.
>
> If they care about referring to the contents of that message, they can
> refer to it in their own copy and make sure they are really looking at
> the same thing by comparing the sequence number in the netlink ACK to
> the one they used in the netlink header they gave to the kernel in the
> sendmsg() call.
>
> What happens now is pure duplication, and for such huge netlink
> messages it's really not smart at all.
>
for errors, we need to give the user something back. This has been the
behavior for 80 years now. Giving them a HUGE message
back is rediculuos(tm). Ive had enough of SCTP doing that.
We need to cap it - sort of what ICMP does.
ICMP caps at 64B; something like 128B is reasonable.
cheers,
jamal
next prev parent reply other threads:[~2013-11-09 13:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 18:57 [PATCH net] netlink: fix netlink_ack with large messages Jiri Benc
2013-11-08 20:07 ` David Miller
2013-11-09 0:04 ` Thomas Graf
2013-11-09 5:00 ` David Miller
2013-11-09 13:43 ` Jamal Hadi Salim [this message]
2013-11-09 18:03 ` Pablo Neira Ayuso
2013-11-12 15:29 ` Jiri Benc
2013-11-12 19:35 ` David Miller
2013-11-13 11:25 ` Jiri Benc
2013-11-13 20:43 ` David Miller
2013-11-09 19:27 ` David Miller
2013-11-09 19:49 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527E3C17.1080508@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jbenc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox