From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Alexei Starovoitov <ast@plumgrid•com>,
"David S. Miller" <davem@davemloft•net>
Cc: Eric Dumazet <edumazet@google•com>,
netdev@vger•kernel.org,
Maciej Zenczykowski <zenczykowski@gmail•com>
Subject: Re: [PATCH net] core/dev: do not ignore dmac in dev_forward_skb()
Date: Tue, 12 Nov 2013 09:49:29 +0100 [thread overview]
Message-ID: <5281EB99.5000104@6wind.com> (raw)
In-Reply-To: <1384206735-4226-1-git-send-email-ast@plumgrid.com>
Le 11/11/2013 22:52, Alexei Starovoitov a écrit :
> commit 06a23fe31ca3
> ("core/dev: set pkt_type after eth_type_trans() in dev_forward_skb()")
> and refactoring 64261f230a91
> ("dev: move skb_scrub_packet() after eth_type_trans()")
>
> are forcing pkt_type to be PACKET_HOST when skb traverses veth.
>
> which means that ip forwarding will kick in inside netns
> even if skb->eth->h_dest != dev->dev_addr
>
> Revert offending commit
>
> Fixes: 06a23fe31ca3 ("core/dev: set pkt_type after eth_type_trans() in dev_forward_skb()")
> CC: Maciej Zenczykowski <zenczykowski@gmail•com>
> CC: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> Signed-off-by: Alexei Starovoitov <ast@plumgrid•com>
skb_scrub_packet() is also called after eth_type_trans() in ip_tunnel_rcv().
I do it to be consistent with dev_forward_skb(), thus it should be inverted too.
prev parent reply other threads:[~2013-11-12 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 21:52 [PATCH net] core/dev: do not ignore dmac in dev_forward_skb() Alexei Starovoitov
2013-11-12 0:39 ` Maciej Żenczykowski
2013-11-12 1:12 ` Alexei Starovoitov
2013-11-12 5:25 ` Isaku Yamahata
2013-11-12 8:49 ` Nicolas Dichtel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5281EB99.5000104@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=ast@plumgrid$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=zenczykowski@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox