Subject: Re: [PATCH] net/7990: Make lance_private.name const

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 13 Nov 2013 03:04:15 +0300

On 11/13/2013 01:44 AM, Geert Uytterhoeven wrote:

>>>>> @@ -100,7 +100,7 @@ struct lance_init_block {
>>>>>      */
>>>>>     struct lance_private
>>>>>     {
>>>>> -        char *name;
>>>>> +        const char *name;

>>>>      Indent with tab, not spaces, please.

>>> This whole file is %99 space indentation, you really can't blame
>>> Geert for this.

>>     It's never late to fix some.

> That would be a separate patch. Care to create and send it?

    I wasn't telling you to fix all of them, just the ones you touched anyway. 
I don't see why the separate patch is needed for that.

>> And remember about checkpatch.pl which was hardly content with the patch.

> Only because checkpatch looks at the _new_ lines, and doesn't compare the
> styles of the old and new lines.

    Care to fix it? :-)

> Gr{oetje,eeting}s,

>                          Geert

WBR, Sergei