From: Ding Tianhong <dingtianhong@huawei•com>
To: Veaceslav Falico <vfalico@redhat•com>
Cc: Jay Vosburgh <fubar@us•ibm.com>,
Andy Gospodarek <andy@greyhouse•net>,
"David S. Miller" <davem@davemloft•net>,
Nikolay Aleksandrov <nikolay@redhat•com>,
Netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net v2] bonding: add ip checks when store ip target
Date: Thu, 14 Nov 2013 18:23:16 +0800 [thread overview]
Message-ID: <5284A494.5020408@huawei.com> (raw)
In-Reply-To: <20131114101028.GQ19702@redhat.com>
On 2013/11/14 18:10, Veaceslav Falico wrote:
> On Thu, Nov 14, 2013 at 10:35:44AM +0800, Ding Tianhong wrote:
> ...snip...
>> - newtarget = in_aton(buf + 1);
>> + if (!in4_pton(buf + 1, -1, (u8 *)&newtarget, -1, NULL) ||
>> + newtarget == 0) {
>
> Good catch on that newtarget verification, forgot to add it. However, the
> previous checked not only for all-zeroes, but also for the broadcast, so
> it'd be great if you could maintain the previous functionality/checks.
>
> Or, even better, you could do something like SCTP does in
> IS_IPV4_UNUSABLE_ADDRESS():
>
> 353 #define IS_IPV4_UNUSABLE_ADDRESS(a) \
> 354 ((htonl(INADDR_BROADCAST) == a) || \
> 355 ipv4_is_multicast(a) || \
> 356 ipv4_is_zeronet(a) || \
> 357 ipv4_is_test_198(a) || \
> 358 ipv4_is_anycast_6to4(a))
>
> It's up to you, though, I think that either way works good - it's
> sysadmin's job to know which addresses can/have to be used.
>
> Also, fix the identation.
>
> Thanks!
>
ok
>> + pr_err("%s: invalid ARP target %pI4 specified for addition\n",
>> + bond->dev->name, &newtarget);
>> + goto out;
>> + }
>> /* look for adds */
>> if (buf[0] == '+') {
>> - if ((newtarget == 0) || (newtarget == htonl(INADDR_BROADCAST))) {
>> - pr_err("%s: invalid ARP target %pI4 specified for addition\n",
>> - bond->dev->name, &newtarget);
>> - goto out;
>> - }
>> -
>> if (bond_get_targets_ip(targets, newtarget) != -1) { /* dup */
>> pr_err("%s: ARP target %pI4 is already present\n",
>> bond->dev->name, &newtarget);
> ...snip...
>
> .
>
prev parent reply other threads:[~2013-11-14 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 2:35 [PATCH net v2] bonding: add ip checks when store ip target Ding Tianhong
2013-11-14 10:10 ` Veaceslav Falico
2013-11-14 10:23 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284A494.5020408@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@redhat$(echo .)com \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox