From: Alexander Duyck <alexander.duyck@gmail•com>
To: David Miller <davem@davemloft•net>, alexander.h.duyck@intel•com
Cc: netdev@vger•kernel.org, edumazet@google•com, herbert@gondor•apana.org
Subject: Re: [PATCH] net: Do not include padding in TCP GRO checksum
Date: Thu, 14 Nov 2013 21:34:14 -0800 [thread overview]
Message-ID: <5285B256.9060605@gmail.com> (raw)
In-Reply-To: <20131114.230821.139211038449295349.davem@davemloft.net>
On 11/14/2013 08:08 PM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@intel•com>
> Date: Thu, 14 Nov 2013 17:18:18 -0800
>
>> I haven't had a chance to test this much yet and I am not that familiar
>
> As Eric mentioned, unless you tested on big endian, chances are you
> didn't test this at all. :-)
>
Actually I had tested it very breifly, but with Rx checksum offloads
still enabled.
> You're accessing the IPv4/IPv6 length fields without converting it
> to CPU endian.
Yeah, I realized that after I hit the BUG_ON in skb_checksum.
I'll be submitting a v2 in the morning with some tested code. The only
difficult part is that I don't have any devices that generate
CHECKSUM_COMPLETE. I think if there is padding I will probably just
fall back to the CHECKSUM_NONE case since that seems to be what
IPv4/IPv6 does in their receive calls when they call pskb_trim_rcsum on
padded frames.
Thanks,
Alex
next prev parent reply other threads:[~2013-11-15 5:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 1:18 [PATCH] net: Do not include padding in TCP GRO checksum Alexander Duyck
2013-11-15 1:26 ` Eric Dumazet
2013-11-15 4:08 ` David Miller
2013-11-15 5:34 ` Alexander Duyck [this message]
2013-11-15 4:20 ` Herbert Xu
2013-11-15 6:00 ` Alexander Duyck
2013-11-18 20:44 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5285B256.9060605@gmail.com \
--to=alexander.duyck@gmail$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox