From: Daniel Mack <zonque@gmail•com>
To: Mugunthan V N <mugunthanvnm@ti•com>, netdev@vger•kernel.org
Cc: davem@davemloft•net
Subject: Re: [PATCH] net: ethernet: ti/cpsw: do not crash on single-MAC machines during resume
Date: Fri, 15 Nov 2013 08:01:38 +0100 [thread overview]
Message-ID: <5285C6D2.40007@gmail.com> (raw)
In-Reply-To: <5284CB99.2020707@ti.com>
On 11/14/2013 02:09 PM, Mugunthan V N wrote:
> On Thursday 14 November 2013 06:26 PM, Daniel Mack wrote:
>> On 11/14/2013 01:45 PM, Mugunthan V N wrote:
>>> On Wednesday 13 November 2013 06:23 PM, Daniel Mack wrote:
>>>> To prevent Oopses, cpsw_suspend() should only soft-reset sliver 1
>>>> on dual MAC enabled machines.
>>>>
>>>> Signed-off-by: Daniel Mack <zonque@gmail•com>
>>>> ---
>>>> drivers/net/ethernet/ti/cpsw.c | 5 ++++-
>>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
>>>> index edd3e79..702b063 100644
>>>> --- a/drivers/net/ethernet/ti/cpsw.c
>>>> +++ b/drivers/net/ethernet/ti/cpsw.c
>>>> @@ -2173,8 +2173,11 @@ static int cpsw_suspend(struct device *dev)
>>>>
>>>> if (netif_running(ndev))
>>>> cpsw_ndo_stop(ndev);
>>>> +
>>>> soft_reset("sliver 0", &priv->slaves[0].sliver->soft_reset);
>>>> - soft_reset("sliver 1", &priv->slaves[1].sliver->soft_reset);
>>>> + if (priv->data.dual_emac)
>>>> + soft_reset("sliver 1", &priv->slaves[1].sliver->soft_reset);
>>> Is this tested on a system with both ports in switch mode?
>> Nope. I got an Ooops when I tried to suspend a machine that has only one
>> slave configured in DTS.
>
> But the changes above will fail with system with two ports and in switch
> mode.
>
>>
>>> I don't think this will not work with both ports in switch mode.
>> Why? Isn't priv->data.dual_emac in that case? The same condition is
>> checked for in cpsw_remove().
> In cpsw_remove that check is used to unregister the second network
> interface registered for same device for port 2. Now I got the issue,
> this has to be done via for_each_slave().
Aah, right, thanks :) Will repost.
Daniel
next prev parent reply other threads:[~2013-11-15 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 12:53 [PATCH] net: ethernet: ti/cpsw: do not crash on single-MAC machines during resume Daniel Mack
2013-11-14 12:45 ` Mugunthan V N
2013-11-14 12:56 ` Daniel Mack
2013-11-14 13:09 ` Mugunthan V N
2013-11-15 7:01 ` Daniel Mack [this message]
2013-11-14 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5285C6D2.40007@gmail.com \
--to=zonque@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox