From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Johannes Berg <johannes@sipsolutions•net>,
David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, linux-wimax@intel•com,
bsingharora@gmail•com, netfilter-devel@vger•kernel.org,
alex.bluesman.smirnov@gmail•com, dbaryshkov@gmail•com
Subject: Re: [PATCH 0/9] genetlink: reduce ops size and complexity (v2)
Date: Fri, 15 Nov 2013 09:45:22 -0500 [thread overview]
Message-ID: <52863382.2060309@mojatatu.com> (raw)
In-Reply-To: <1384521794.14295.5.camel@jlt4.sipsolutions.net>
Are we killing APIs that are already used?
At least that patches that Dave sucked in do. Out of tree
users dont matter?
cheers,
jamal
On 11/15/13 08:23, Johannes Berg wrote:
> On Fri, 2013-11-15 at 14:18 +0100, Johannes Berg wrote:
>
>> I've been eyeing the multicast groups as well
>
> Of course, there are also *much* fewer mcast groups, so the saving isn't
> nearly as big. But we still have some oddball code to register them all,
> basically
>
> err = register_mc_group();
> if (err)
> goto unregister_family;
>
> (since we have to register the family first, afaict)
>
> sometimes a few of those back to back, and it'd be nicer on the users if
> that just went away and was
>
> family.mcast_groups = my_groups;
> family.n_mcast_groups = ARRAY_SIZE(my_groups);
> family.ops = my_ops;
> family.n_ops = ARRAY_SIZE(my_ops);
> return genl_register_family(&family);
>
> since nobody uses them dynamically anyway, afaict.
>
> johannes
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-11-15 14:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 9:14 [RFC 0/7] genetlink: reduce ops size and complexity Johannes Berg
2013-11-14 9:14 ` [RFC 1/7] taskstats: use genl_register_family_with_ops() Johannes Berg
2013-11-14 9:14 ` [RFC 2/7] hsr: " Johannes Berg
2013-11-14 9:14 ` [RFC 3/7] ieee802154: " Johannes Berg
2013-11-14 9:14 ` [RFC 4/7] wimax: " Johannes Berg
2013-11-14 9:14 ` [RFC 5/7] genetlink: remove genl_register_ops/genl_unregister_ops Johannes Berg
2013-11-14 9:14 ` [RFC 6/7] genetlink: register family ops as array Johannes Berg
2013-11-14 9:14 ` [RFC 7/7] genetlink: allow making ops const Johannes Berg
2013-11-14 13:41 ` [RFC 8/7] genetlink: make all genl_ops users const Johannes Berg
2013-11-14 14:01 ` [RFC 9/7] genetlink: make genl_ops flags a u8 and move to end Johannes Berg
2013-11-14 14:36 ` [RFC 0/7] genetlink: reduce ops size and complexity Johannes Berg
2013-11-14 16:02 ` Johannes Berg
2013-11-14 16:14 ` [PATCH 0/9] genetlink: reduce ops size and complexity (v2) Johannes Berg
2013-11-14 16:14 ` [PATCH 1/9] taskstats: use genl_register_family_with_ops() Johannes Berg
2013-11-14 16:14 ` [PATCH 2/9] hsr: " Johannes Berg
2013-11-14 16:14 ` [PATCH 3/9] ieee802154: " Johannes Berg
2013-11-14 16:14 ` [PATCH 4/9] wimax: " Johannes Berg
2013-11-14 16:14 ` [PATCH 5/9] genetlink: remove genl_register_ops/genl_unregister_ops Johannes Berg
2013-11-14 16:14 ` [PATCH 6/9] genetlink: register family ops as array Johannes Berg
2013-11-14 16:14 ` [PATCH 7/9] genetlink: allow making ops const Johannes Berg
2013-11-14 16:14 ` [PATCH 8/9] genetlink: make all genl_ops users const Johannes Berg
2013-11-14 16:14 ` [PATCH 9/9] genetlink: make genl_ops flags a u8 and move to end Johannes Berg
2013-11-14 22:12 ` [PATCH 0/9] genetlink: reduce ops size and complexity (v2) David Miller
2013-11-15 13:18 ` Johannes Berg
2013-11-15 13:23 ` Johannes Berg
2013-11-15 14:45 ` Jamal Hadi Salim [this message]
2013-11-16 1:54 ` David Miller
2013-11-16 1:53 ` David Miller
2013-11-17 9:12 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52863382.2060309@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=alex.bluesman.smirnov@gmail$(echo .)com \
--cc=bsingharora@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dbaryshkov@gmail$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linux-wimax@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox