From: wangweidong <wangweidong1@huawei•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: <davem@davemloft•net>, <gerrit@erg•abdn.ac.uk>,
<kuznet@ms2•inr.ac.ru>, <jmorris@namei•org>,
<yoshfuji@linux-ipv6•org>, <kaber@trash•net>,
<vyasevich@gmail•com>, <nhorman@tuxdriver•com>,
<dccp@vger•kernel.org>, <netdev@vger•kernel.org>,
<linux-sctp@vger•kernel.org>, <dingtianhong@huawei•com>
Subject: Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo
Date: Tue, 19 Nov 2013 12:44:10 +0800 [thread overview]
Message-ID: <528AEC9A.5050100@huawei.com> (raw)
In-Reply-To: <1384833653.8604.84.camel@edumazet-glaptop2.roam.corp.google.com>
On 2013/11/19 12:00, Eric Dumazet wrote:
> On Mon, 2013-11-18 at 19:58 -0800, Eric Dumazet wrote:
>
>> But sctp is not tcp ;)
>>
>> sctp_copy_sock() is doing some clever/partial copy of the socket, so
>> please fix it ;)
>>
>> No idea why it's not doing the normal copy of the socket.
>
> BTW, not doing the full copy means for example that SO_MAX_PACING_RATE
> is broken for SCTP.
>
>
>
The dccp will copy the geniric socket, too. And You mean to say that only
add the copies in sctp_copy_sock().
Thanks.
>
>
>
>
next prev parent reply other threads:[~2013-11-19 4:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 2:47 [PATCH 0/2] ipv6: fix the missing copies when memcpy ipv6_pinfo Wang Weidong
2013-11-19 2:47 ` [PATCH 1/2] ipv6: add helper function for copy addrs from old sock Wang Weidong
2013-11-19 2:47 ` [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo Wang Weidong
2013-11-19 3:14 ` Hannes Frederic Sowa
2013-11-19 3:32 ` wangweidong
2013-11-19 3:58 ` Eric Dumazet
2013-11-19 4:00 ` Eric Dumazet
2013-11-19 4:44 ` wangweidong [this message]
2013-11-19 11:35 ` Daniel Borkmann
2013-11-19 14:23 ` Eric Dumazet
2013-11-19 14:26 ` Daniel Borkmann
2013-11-19 15:25 ` Vlad Yasevich
2013-11-19 11:04 ` Daniel Borkmann
2013-11-19 11:09 ` wangweidong
2013-11-19 3:55 ` Eric Dumazet
2013-11-19 4:38 ` wangweidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528AEC9A.5050100@huawei.com \
--to=wangweidong1@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dccp@vger$(echo .)kernel.org \
--cc=dingtianhong@huawei$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=gerrit@erg$(echo .)abdn.ac.uk \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox