From: wangweidong <wangweidong1@huawei•com>
To: Daniel Borkmann <dborkman@redhat•com>, <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, <linux-sctp@vger•kernel.org>,
Eric Dumazet <eric.dumazet@gmail•com>
Subject: Re: [PATCH net] net: sctp: fix copying sk_v6_rcv_saddr in sctp_v6_create_accept_sk
Date: Tue, 19 Nov 2013 19:08:11 +0800 [thread overview]
Message-ID: <528B469B.3060702@huawei.com> (raw)
In-Reply-To: <1384858284-2246-1-git-send-email-dborkman@redhat.com>
On 2013/11/19 18:51, Daniel Borkmann wrote:
> Wang reported an issue that lksctp's test_getname_v6 seems to fail.
>
> The issue is that we do not copy sk_v6_rcv_saddr over to the new
> socket, although the comment above says so regarding rcv_saddr.
>
> Commit 914e1c8b6980 ("sctp: Inherit all socket options from parent
> correctly.") originally moved that over to sctp_copy_sock(), but
> after commit efe4208f47f9 ("ipv6: make lookups simpler and faster")
> this no longer holds and the actual value of sk_v6_rcv_saddr was
> no longer being migrated.
>
> With this patch, the lksctp test suite passes again for IPv6.
>
> Fixes: efe4208f47f9 ("ipv6: make lookups simpler and faster")
> Signed-off-by: Daniel Borkmann <dborkman@redhat•com>
> Signed-off-by: Wang Weidong <wangweidong1@huawei•com>
> Cc: Eric Dumazet <eric.dumazet@gmail•com>
> ---
> net/sctp/ipv6.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c
> index 7567e6f..be08592 100644
> --- a/net/sctp/ipv6.c
> +++ b/net/sctp/ipv6.c
> @@ -661,6 +661,7 @@ static struct sock *sctp_v6_create_accept_sk(struct sock *sk,
> * and getpeername().
> */
> sctp_v6_to_sk_daddr(&asoc->peer.primary_addr, newsk);
> + newsk->sk_v6_rcv_saddr = sk->sk_v6_rcv_saddr;
>
> sk_refcnt_debug_inc(newsk);
>
Acked-by: Wang Weidong <wangweidong1@huawei•com>
>
next prev parent reply other threads:[~2013-11-19 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 10:51 [PATCH net] net: sctp: fix copying sk_v6_rcv_saddr in sctp_v6_create_accept_sk Daniel Borkmann
2013-11-19 11:08 ` wangweidong [this message]
2013-11-19 15:38 ` Vlad Yasevich
2013-11-19 15:46 ` Daniel Borkmann
2013-11-19 21:10 ` David Miller
2013-11-21 6:49 ` wangweidong
2013-11-21 9:08 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528B469B.3060702@huawei.com \
--to=wangweidong1@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox