Subject: Re: [PATCH v2 net] af_packet: block BH in prb_shutdown_retire_blk_timer()

From: Daniel Borkmann <[email-masked]>
Date: Fri, 29 Nov 2013 10:19:29 +0100

On 11/29/2013 09:53 AM, Veaceslav Falico wrote:
> Currently we're using plain spin_lock() in prb_shutdown_retire_blk_timer(),
> however the timer might fire right in the middle and thus try to re-aquire
> the same spinlock, leaving us in a endless loop.
>
> To fix that, use the spin_lock_bh() to block it.
>
> CC: "David S. Miller" <[email-masked]>
> CC: Daniel Borkmann <[email-masked]>
> CC: Willem de Bruijn <[email-masked]>
> CC: Phil Sutter <[email-masked]>
> CC: Eric Dumazet <[email-masked]>
> Reported-by: Jan Stancek <[email-masked]>
> Tested-by: Jan Stancek <[email-masked]>
> Signed-off-by: Veaceslav Falico <[email-masked]>

Fixes: f6fb8f100b80 ("af-packet: TPACKET_V3 flexible buffer implementation.")
Acked-by: Daniel Borkmann <[email-masked]>

Thanks everyone!