From: Wang Weidong <wangweidong1@huawei•com>
To: Vlad Yasevich <vyasevich@gmail•com>, <nhorman@tuxdriver•com>,
David Miller <davem@davemloft•net>
Cc: <linux-sctp@vger•kernel.org>, <netdev@vger•kernel.org>,
<dingtianhong@huawei•com>
Subject: Re: [PATCH v2] sctp: check the rto_min and rto_max
Date: Tue, 3 Dec 2013 09:58:19 +0800 [thread overview]
Message-ID: <529D3ABB.8040908@huawei.com> (raw)
In-Reply-To: <529C9D13.10107@gmail.com>
On 2013/12/2 22:45, Vlad Yasevich wrote:
> On 12/01/2013 08:45 PM, Wang Weidong wrote:
>> rto_min should be smaller than rto_max while rto_max should be larger
>> than rto_min. so just add the check.
>>
>> Acked-by: Neil Horman <nhorman@tuxdriver•com>
>> Signed-off-by: Wang Weidong <wangweidong1@huawei•com>
>> ---
>> net/sctp/sysctl.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
>> index 6b36561..7637e8e 100644
>> --- a/net/sctp/sysctl.c
>> +++ b/net/sctp/sysctl.c
>> @@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = {
>> .mode = 0644,
>> .proc_handler = proc_dointvec_minmax,
>> .extra1 = &one,
>> - .extra2 = &timer_max
>> + .extra2 = &init_net.sctp.rto_max
>> },
>> {
>> .procname = "rto_max",
>> @@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = {
>> .maxlen = sizeof(unsigned int),
>> .mode = 0644,
>> .proc_handler = proc_dointvec_minmax,
>> - .extra1 = &one,
>> + .extra1 = &init_net.sctp.rto_min,
>> .extra2 = &timer_max
>> },
>> {
>>
>
> So, now if initial namespace change rto_min and rto_max, it limits the
> values that another namespace can set? I don't think so.
Hm, you are right.
I think we have two path to set the rto_min or rto_max: 1)systclt, 2)setsockopt
In 2) we can make the assoc or sk rto_max smaller than rto_min. so we should a
check in the sctp_setsockopt_rtoinfo or proc_handler.
>
> If you are looking to fix an issue where rto_max may be set below
> rto_min, then do a separate proc_handler.
I will try to add a separate proc_handler.
Thanks.
>
> -vlad
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2013-12-03 1:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 1:45 [PATCH v2] sctp: check the rto_min and rto_max Wang Weidong
2013-12-02 12:15 ` Wang Weidong
2013-12-02 14:45 ` Vlad Yasevich
2013-12-03 1:58 ` Wang Weidong [this message]
2013-12-03 6:28 ` [PATCH v3] " Wang Weidong
2013-12-03 12:39 ` Vlad Yasevich
2013-12-04 2:46 ` Wang Weidong
2013-12-04 14:24 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529D3ABB.8040908@huawei.com \
--to=wangweidong1@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dingtianhong@huawei$(echo .)com \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox