Subject: Re: [PATCH 5/5] net_sched: Fail if missing mandatory action operation methods

From: Jamal Hadi Salim <[email-masked]>
Date: Tue, 03 Dec 2013 19:43:20 -0500

On 12/03/13 11:48, David Miller wrote:

> You are going to return with a lock held on error here.
>
> I was going to tell you not to do these fixups so late in the
> function, inside of the write lock, there is no reason for it.
>
> You should do all of this operation handling at the top of
> the function, before the write lock is taken.
>

yikes;->
do you want the whole set resent or the last one only?

cheers,
jamal