From: Wang Weidong <wangweidong1@huawei•com>
To: Neil Horman <nhorman@tuxdriver•com>
Cc: Vlad Yasevich <vyasevich@gmail•com>,
David Miller <davem@davemloft•net>, <netdev@vger•kernel.org>,
<linux-sctp@vger•kernel.org>
Subject: Re: [PATCH v4] sctp: check the rto_min and rto_max
Date: Fri, 6 Dec 2013 16:48:45 +0800 [thread overview]
Message-ID: <52A18F6D.9010606@huawei.com> (raw)
In-Reply-To: <20131205133217.GA20349@hmsreliant.think-freely.org>
On 2013/12/5 21:32, Neil Horman wrote:
> On Thu, Dec 05, 2013 at 10:19:25AM +0800, Wang Weidong wrote:
>> rto_min should be smaller than rto_max while rto_max should be larger
>> than rto_min. Add two proc_handler for the checking. Add the check in
>> sctp_setsockopt_rtoinfo.
>> delete a blank line in proc_sctp_do_hmac_alg() declaration.
>>
>> Suggested-by: Vlad Yasevich <vyasevich@gmail•com>
>> Signed-off-by: Wang Weidong <wangweidong1@huawei•com>
>> ---
>> net/sctp/socket.c | 5 ++++
>> net/sctp/sysctl.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++----
>> 2 files changed, 74 insertions(+), 5 deletions(-)
>>
>> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
>> index 72046b9..2e1af1b 100644
>> --- a/net/sctp/socket.c
>> +++ b/net/sctp/socket.c
>> @@ -2818,6 +2818,11 @@ static int sctp_setsockopt_rtoinfo(struct sock *sk, char __user *optval, unsigne
>> if (copy_from_user(&rtoinfo, optval, optlen))
>> return -EFAULT;
>>
>> + if (rtoinfo.srto_min < 1 ||
>> + rtoinfo.srto_max > 86400000 ||
> These should be defiend to some descriptive value.
>
>
Hi Neil,
Should I define it in net/sctp/sctp.h, so sysctl.c can use it as well.
Or I just define it in the socket.c same as the definition in sysctl.c?
Regards.
Wang
>
next prev parent reply other threads:[~2013-12-06 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 2:19 [PATCH v4] sctp: check the rto_min and rto_max Wang Weidong
2013-12-05 13:32 ` Neil Horman
2013-12-05 14:07 ` Wang Weidong
2013-12-05 16:25 ` Daniel Borkmann
2013-12-06 1:23 ` Wang Weidong
2013-12-06 8:54 ` Daniel Borkmann
2013-12-06 8:48 ` Wang Weidong [this message]
2013-12-06 9:50 ` Daniel Borkmann
2013-12-06 9:52 ` Wang Weidong
2013-12-06 10:36 ` Wang Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A18F6D.9010606@huawei.com \
--to=wangweidong1@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox