From: "Emilio López" <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public•gmane.org>
To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public•gmane.org,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public•gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public•gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>,
Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public•gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public•gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Srinivas Kandagatla
<srinivas.kandagatla-qxv4g6HH51o@public•gmane.org>
Subject: Re: Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's
Date: Sat, 07 Dec 2013 10:34:17 -0300 [thread overview]
Message-ID: <52A323D9.5080806@elopez.com.ar> (raw)
In-Reply-To: <1455361.VIrFSPex2v@flatron>
El 07/12/13 09:50, Tomasz Figa escribió:
> On Saturday 07 of December 2013 12:46:16 Maxime Ripard wrote:
>> On Sat, Dec 07, 2013 at 12:12:26PM +0100, Tomasz Figa wrote:
>>> On Saturday 07 of December 2013 11:27:10 Maxime Ripard wrote:
>>>> Chen-Yu, Mike,
>>>>
>>>> On Sat, Dec 07, 2013 at 01:29:37AM +0800, Chen-Yu Tsai wrote:
>>>>> The Allwinner A20 has an ethernet controller that seems to be
>>>>> an early version of Synopsys DesignWare MAC 10/100/1000 Universal,
>>>>> which is supported by the stmmac driver.
>>>>>
>>>>> Allwinner's GMAC requires setting additional registers in the SoC's
>>>>> clock control unit.
>>>>>
>>>>> The exact version of the DWMAC IP that Allwinner uses is unknown,
>>>>> thus the exact feature set is unknown.
>>>>>
>>>>> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public•gmane.org>
>>>>> ---
>>>>> .../bindings/net/allwinner,sun7i-gmac.txt | 22 +++++++
>>>>> drivers/net/ethernet/stmicro/stmmac/Kconfig | 12 ++++
>>>>> drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
>>>>> drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 76 ++++++++++++++++++++++
>>>>> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 3 +
>>>>> .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 +
>>>>> 6 files changed, 117 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun7i-gmac.txt b/Documentation/devicetree/bindings/net/allwinner,sun7i-gmac.txt
>>>>> new file mode 100644
>>>>> index 0000000..271554a
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/net/allwinner,sun7i-gmac.txt
>>>>> @@ -0,0 +1,22 @@
>>>>> +* Allwinner GMAC ethernet controller
>>>>> +
>>>>> +This device is a platform glue layer for stmmac.
>>>>> +Please see stmmac.txt for the other unchanged properties.
>>>>> +
>>>>> +Required properties:
>>>>> + - compatible: Should be "allwinner,sun7i-gmac"
>>>>
>>>> Please use sun7i-a20-gmac here.
>>>>
>>>>> + - reg: Address and length of register set for the device and corresponding
>>>>> + clock control
>>>>>
>>>>> +Examples:
>>>>> +
>>>>> + gmac: ethernet@01c50000 {
>>>>> + compatible = "allwinner,sun7i-gmac";
>>>>> + reg = <0x01c50000 0x10000>,
>>>>> + <0x01c20164 0x4>;
>>>>
>>>> This is actually a clock, and should probably be registered in the
>>>> common clock framework.
>>>>
>>>> Mike: This small register actually is a regular muxer/divider, except
>>>> that it has some bits that are of interest to the ethernet controller
>>>> (for example to set wether it's using GMII or RGMII to communicate
>>>> with the phy), that, as far as I'm aware of, aren't really fitting
>>>> into the CCF.
>>>>
>>>> Do you have some recommendation on how to proceed?
>>>>
>>>> Maybe make a thin "real" clock driver in this hardware glue, that
>>>> provides !exported function to set this *GMII thing.
>>>
>>> Is this register part of a bigger IP block that manages clocks for other
>>> IP blocks than stmmac as well? If not, I don't see a point of exporting
>>> a clock from inside of the GMAC "domain" just to feed it back into it
>>> as the only user.
>>
>> This register is actually part of the SoC clock controller. So it sits
>> right beside the other clocks registers controlling the clocks of the
>> other devices, and is not part of the GMAC IP itself.
>
> Is there any description for GMAC_IF_TYPE_RGMII and GMAC_TX_CLK fields?
>
> Name of the latter sounds like a normal clock mux, but the former is
> just a mystery (especially why it is a part of the clock controller).
You can find the register documented on page 89, table 1.5.4.65 of
http://dl.linux-sunxi.org/A20/A20%20User%20Manual%202013-03-22.pdf
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public•gmane.org
For more options, visit https://groups.google.com/groups/opt_out.
next prev parent reply other threads:[~2013-12-07 13:34 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 17:29 [PATCH 00/10] net: stmmac: Add sun7i GMAC glue layer Chen-Yu Tsai
[not found] ` <1386350983-13281-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2013-12-06 17:29 ` [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware Chen-Yu Tsai
[not found] ` <1386350983-13281-2-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2013-12-07 10:33 ` Maxime Ripard
2013-12-09 2:43 ` Chen-Yu Tsai
[not found] ` <CAGb2v65YOSq_BMWSzSHX8w_hbo+0vwquBT2pnLuwNVZkWRfLvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-09 10:09 ` Hans de Goede
2013-12-10 20:05 ` Maxime Ripard
2013-12-12 4:31 ` Chen-Yu Tsai
2013-12-09 7:14 ` Giuseppe CAVALLARO
[not found] ` <52A56DE5.5010206-qxv4g6HH51o@public.gmane.org>
2013-12-09 7:26 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 02/10] net: stmmac: Honor DT parameter to force DMA store and forward mode Chen-Yu Tsai
2013-12-06 21:26 ` David Miller
[not found] ` <20131206.162606.2277176361893801778.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-12-07 1:19 ` Chen-Yu Tsai
2013-12-07 1:23 ` Chen-Yu Tsai
[not found] ` <CAGb2v67ZNtbQm+ZW5v_3wNbz1=oLhXks6gbTSjLYa=Nnoz8w-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-07 10:07 ` maxime.ripard
2013-12-07 11:06 ` Tomasz Figa
2013-12-09 2:59 ` Chen-Yu Tsai
[not found] ` <CAGb2v64BMNjbbc7j2XesuPEXZV+RnjtP1sAPQ4icU=-wjh3YNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-10 20:10 ` maxime.ripard
2013-12-06 17:29 ` [PATCH 03/10] net: stmmac: Use platform data tied with compatible strings Chen-Yu Tsai
2013-12-06 21:26 ` David Miller
[not found] ` <20131206.162633.125107323851595113.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-12-07 2:13 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's Chen-Yu Tsai
[not found] ` <1386350983-13281-5-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2013-12-07 10:27 ` Maxime Ripard
2013-12-07 11:12 ` Tomasz Figa
2013-12-07 11:46 ` Maxime Ripard
2013-12-07 12:50 ` Tomasz Figa
2013-12-07 13:34 ` Emilio López [this message]
2013-12-09 11:10 ` srinivas kandagatla
[not found] ` <52A5A52C.50605-qxv4g6HH51o@public.gmane.org>
2013-12-09 16:16 ` Hans de Goede
[not found] ` <52A5ECF4.6030301-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-09 17:56 ` Chen-Yu Tsai
[not found] ` <CAGb2v64LNxnz--vn0u9zwmt7MQJZ=uz2fs0H3zDSse_XDfdK4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-09 19:04 ` Hans de Goede
[not found] ` <52A61435.6040803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-12-10 20:14 ` Maxime Ripard
2013-12-09 17:34 ` Chen-Yu Tsai
[not found] ` <CAGb2v67WiCaMpJEzA_X6o7uOu6i3w3FCEz7=N5HY0amQb01SZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-10 14:59 ` srinivas kandagatla
[not found] ` <52A72C6D.60100-qxv4g6HH51o@public.gmane.org>
2013-12-10 20:23 ` Maxime Ripard
2013-12-11 12:17 ` Chen-Yu Tsai
[not found] ` <CAGb2v64qQvqJSicA6MTAxeh1sGjWY=Pk=vDq=9J3pTQW+wkXrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-11 14:45 ` srinivas kandagatla
[not found] ` <52A87A74.8040807-qxv4g6HH51o@public.gmane.org>
2013-12-12 7:27 ` Chen-Yu Tsai
2013-12-12 9:04 ` Maxime Ripard
2013-12-12 10:31 ` Chen-Yu Tsai
2013-12-13 10:38 ` Maxime Ripard
2013-12-24 3:27 ` Chen-Yu Tsai
[not found] ` <CAGb2v64Q1PSMw_nULBHMR5eOC44hWBPewchxE_4sO+4XN8_sDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-02 13:11 ` srinivas kandagatla
[not found] ` <52C5656A.4060402-qxv4g6HH51o@public.gmane.org>
2014-01-07 10:24 ` Chen-Yu Tsai
2013-12-09 11:21 ` srinivas kandagatla
[not found] ` <52A5A7B2.4000509-qxv4g6HH51o@public.gmane.org>
2013-12-09 13:44 ` Sergei Shtylyov
[not found] ` <52A5C950.7070903-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-12-09 15:45 ` Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 05/10] ARM: dts: sun7i: Add GMAC controller node to sun7i DTSI Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 06/10] ARM: dts: sun7i: Add pin muxing options for the GMAC Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 07/10] ARM: dts: sun7i: cubietruck: Enable " Chen-Yu Tsai
2013-12-06 21:09 ` Florian Fainelli
[not found] ` <CAGVrzcb_r9_p4urz4XkE2A-G85KAHJa4PJ=Gt9a4RPYQNJ6j0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-07 1:35 ` Chen-Yu Tsai
[not found] ` <CAGb2v64yFhkTXvdq=1VpemULhXew-5fvmSoTBzEb6iFDiSqy1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-07 1:57 ` Florian Fainelli
[not found] ` <CAGVrzcaxV88dU3vEVGUiEQihUHLxq+QvQVQ6VvmOFVRsqbbX7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-09 2:55 ` Chen-Yu Tsai
[not found] ` <CAGb2v675Cg6S512zfM1z4b+wqE_PesDGWdgcmpzWmPzyzXqbeA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-09 17:48 ` Florian Fainelli
2013-12-10 4:11 ` Chen-Yu Tsai
[not found] ` <CAGb2v665xtY4m4uCTb_iMojG+ox0HvyCgz6p0P7oxJVvZ0SW9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-10 17:23 ` Florian Fainelli
2013-12-13 10:21 ` Giuseppe CAVALLARO
2013-12-06 17:29 ` [PATCH 08/10] ARM: dts: sun7i: cubieboard2: Enable GMAC instead of EMAC Chen-Yu Tsai
[not found] ` <1386350983-13281-9-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2013-12-06 21:10 ` Florian Fainelli
2013-12-06 17:29 ` [PATCH 09/10] ARM: dts: sun7i: olinuxino-micro: " Chen-Yu Tsai
2013-12-06 17:29 ` [PATCH 10/10] ARM: dts: sun7i: Add ethernet alias for GMAC Chen-Yu Tsai
[not found] ` <1386350983-13281-11-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2013-12-07 10:15 ` Maxime Ripard
2013-12-07 16:20 ` Chen-Yu Tsai
2013-12-06 20:52 ` [PATCH 00/10] net: stmmac: Add sun7i GMAC glue layer Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A323D9.5080806@elopez.com.ar \
--to=emilio-0z03zujred5oxf6tv1qg9q@public$(echo .)gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public$(echo .)gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public$(echo .)gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=peppe.cavallaro-qxv4g6HH51o@public$(echo .)gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=srinivas.kandagatla-qxv4g6HH51o@public$(echo .)gmane.org \
--cc=wens-jdAy2FN1RRM@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox