Subject: Re: [PATCH net-next 07/12] net/mlx4_en: Configure the XPS queue mapping on driver load

From: Sergei Shtylyov <[email-masked]>
Date: Sun, 08 Dec 2013 19:28:30 +0400

Hello.

On 08-12-2013 16:35, Amir Vadai wrote:

> From: Ido Shamay <[email-masked]>

> Only TX rings of User Piority 0 are mapped.
> TX rings of other UP's are using UP 0 mapping.
> XPS is not in use when num_tc is set.

> Signed-off-by: Ido Shamay <[email-masked]>
> Signed-off-by: Amir Vadai <[email-masked]>
[...]

> diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> index fa33a83..a4cdd7d 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
[...]
> @@ -708,8 +710,9 @@ u16 mlx4_en_select_queue(struct net_device *dev, struct sk_buff *skb);
>   netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev);
>
>   int mlx4_en_create_tx_ring(struct mlx4_en_priv *priv,
> -			   struct mlx4_en_tx_ring **pring,
> -			   int qpn, u32 size, u16 stride, int node);
> +			struct mlx4_en_tx_ring **pring,
> +			int qpn, u32 size, u16 stride,
> +			int node, int queue_index);

    Why you've changed the indentation here -- it was alright before.

>   void mlx4_en_destroy_tx_ring(struct mlx4_en_priv *priv,
>   			     struct mlx4_en_tx_ring **pring);
>   int mlx4_en_activate_tx_ring(struct mlx4_en_priv *priv,

WBR, Sergei