Subject: Re: [PATCH 1/2] macvtap: remove useless codes in macvtap_aio_read() and macvtap_recvmsg()

From: Jason Wang <[email-masked]>
Date: Mon, 09 Dec 2013 11:30:54 +0800

On 12/07/2013 10:38 AM, Vlad Yasevich wrote:
> On 12/06/2013 03:54 PM, Zhi Yong Wu wrote:
>> > From: Zhi Yong Wu <[email-masked]>
>> > 
>> > By checking related codes, it is impossible that ret > len or total_len,
>> > so we should remove some useless coeds in both above functions.
> Looks like commit 6680ec68eff47d36f67b4351bc9836fd6cba9532
> Author: Jason Wang <[email-masked]>
> Date:   Thu Jul 25 13:00:33 2013 +0800
>
>     tuntap: hardware vlan tx support
>
> Introduced a change in tun_put_user() where we can
> never return a length longer then len or total_len.
> This has an effect that is now impossible to signal
> truncated status.  It seems like a potential loss
> of functionality and it might make sense to restore it.
>
> -vlad

True, will send a patch. For macvtap, we'd better also correct current
behaviour to be same with tun.

Thanks