From: Amir Vadai <amirv@mellanox•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Or Gerlitz <ogerlitz@mellanox•com>,
Yevgeny Petrilin <yevgenyp@mellanox•com>,
<netdev@vger•kernel.org>,
Eugenia Emantayev <eugenia@mellanox•com>
Subject: Re: [PATCH net-next 10/12] net/mlx4_en: Add NAPI support for transmit side
Date: Mon, 9 Dec 2013 12:07:58 +0200 [thread overview]
Message-ID: <52A5967E.1030300@mellanox.com> (raw)
In-Reply-To: <1386530536.30495.287.camel@edumazet-glaptop2.roam.corp.google.com>
On 08/12/2013 21:22, Eric Dumazet wrote:
> On Sun, 2013-12-08 at 14:35 +0200, Amir Vadai wrote:
>> From: Eugenia Emantayev <eugenia@mellanox•com>
>>
>> Add NAPI for TX side,
>> implement its support and provide NAPI callback.
>>
>>
>> Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox•com>
>> Signed-off-by: Eugenia Emantayev <eugenia@mellanox•com>
>> Signed-off-by: Amir Vadai <amirv@mellanox•com>
>> ---
>> drivers/net/ethernet/mellanox/mlx4/en_cq.c | 12 ++++++---
>> drivers/net/ethernet/mellanox/mlx4/en_tx.c | 39 +++++++++++++++++++++++-----
>> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 3 +++
>> 3 files changed, 43 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_cq.c b/drivers/net/ethernet/mellanox/mlx4/en_cq.c
>> index 3a098cc..2c60f0c 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/en_cq.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/en_cq.c
>> @@ -161,12 +161,16 @@ int mlx4_en_activate_cq(struct mlx4_en_priv *priv, struct mlx4_en_cq *cq,
>> cq->mcq.comp = cq->is_tx ? mlx4_en_tx_irq : mlx4_en_rx_irq;
>> cq->mcq.event = mlx4_en_cq_event;
>>
>> - if (!cq->is_tx) {
>> + if (cq->is_tx) {
>> + netif_napi_add(cq->dev, &cq->napi, mlx4_en_poll_tx_cq,
>> + MLX4_EN_TX_BUDGET);
>> + } else {
>
> TX completion is not supposed to have a 'budget'.
>
> You should consume all completed descriptors.
>
> BQL should already drive the dynamic of the TX queue.
Actually MLX4_EN_TX_BUDGET is 64 already.
Will use NAPI_POLL_WEIGHT instead in V1.
Amir
next prev parent reply other threads:[~2013-12-09 10:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 12:35 [PATCH net-next 00/12] net/mlx4: Mellanox driver update 08-12-2013 Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 01/12] net/mlx4_en: Reuse mapped memory in RX flow Amir Vadai
2013-12-08 19:20 ` Eric Dumazet
2013-12-09 9:44 ` Amir Vadai
2013-12-09 15:17 ` Eric Dumazet
2013-12-10 9:47 ` Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 02/12] net/mlx4_core: Remove zeroed out of explicit QUERY_FUNC_CAP fields Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 03/12] net/mlx4_core: Rename " Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 04/12] net/mlx4_core: Introduce nic_info new flag in QUERY_FUNC_CAP Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 05/12] net/mlx4_core: Expose physical port id as PF/VF capability Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 06/12] net/mlx4_en: Implement ndo_get_phys_port_id Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 07/12] net/mlx4_en: Configure the XPS queue mapping on driver load Amir Vadai
2013-12-08 15:28 ` Sergei Shtylyov
2013-12-08 15:42 ` Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 08/12] net/mlx4_core: Set CQE/EQE size to 64B by default Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 09/12] net/mlx4_en: Ignore irrelevant hypervisor events Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 10/12] net/mlx4_en: Add NAPI support for transmit side Amir Vadai
2013-12-08 19:22 ` Eric Dumazet
2013-12-09 10:07 ` Amir Vadai [this message]
2013-12-08 12:35 ` [PATCH net-next 11/12] net/mlx4_en: Fix Supported/Advertised link mode reported by ethtool Amir Vadai
2013-12-08 12:35 ` [PATCH net-next 12/12] net/mlx4_core: Check port number for validity before accessing data Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A5967E.1030300@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=eugenia@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox