Subject: Re: [PATCH net-next v2 6/9] net: mv643xx_eth: use phy_init_hw to reset PHY

From: Sebastian Hesselbarth <[email-masked]>
Date: Mon, 09 Dec 2013 21:09:27 +0100

On 12/06/2013 10:01 PM, Florian Fainelli wrote:
> Instead of open-coding a PHY reset through the MII BMCR register, use
> phy_init_hw() which does that for us and will also make sure that PHY
> fixups are applied if required. We also remove a call to phy_reset()
> due to the following sequence of calls in the driver:
>
> phy_scan()
> 	-> phy_connect()
> 		-> phy_connect_direct()
> 			-> phy_attach_direct()
> 				-> phy_init_hw()
>
> and we only have a call to phy_init() after phy_scan().
>
> Signed-off-by: Florian Fainelli <[email-masked]>
> ---
> Changes since v2:
> - improved commit message and explain why phy_reset() can go away
>    entirely

Series tested on mv643xx_eth with Marvell Dove SoC.

Tested-by: Sebastian Hesselbarth <[email-masked]>

>   drivers/net/ethernet/marvell/mv643xx_eth.c | 21 +--------------------
>   1 file changed, 1 insertion(+), 20 deletions(-)