From: Jamal Hadi Salim <jhs@mojatatu•com>
To: David Miller <davem@davemloft•net>
Cc: xiyou.wangcong@gmail•com, David.Laight@aculab•com,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next v3 1/6] net_sched: remove get_stats from tc_action_ops
Date: Fri, 13 Dec 2013 21:59:01 -0500 [thread overview]
Message-ID: <52ABC975.2070308@mojatatu.com> (raw)
In-Reply-To: <20131213.182325.2234215963739207753.davem@davemloft.net>
On 12/13/13 18:23, David Miller wrote:
> Jamal, nobody implements this interface, therefore these extra
> stats are _NEVER_ provided.
>
> This is the end of the discussion, when there are in-tree users
> of this method you can add it back.
Dave, I think that would be a good arguement if the feature was being
provided in a new set of patches today.
I dont see this as any different than removing an something from a UAPI
header nobody knows any user of.
cheers,
jamal
next prev parent reply other threads:[~2013-12-14 2:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 5:47 [PATCH net-next v3 0/6] net_sched: some cleanup and improvments Cong Wang
2013-12-13 5:47 ` [PATCH net-next v3 1/6] net_sched: remove get_stats from tc_action_ops Cong Wang
2013-12-13 10:21 ` David Laight
2013-12-13 18:33 ` Cong Wang
2013-12-13 21:27 ` Jamal Hadi Salim
2013-12-13 21:34 ` Cong Wang
2013-12-13 21:40 ` Jamal Hadi Salim
2013-12-13 21:50 ` Cong Wang
2013-12-13 22:19 ` Jamal Hadi Salim
2013-12-13 23:23 ` David Miller
2013-12-14 2:59 ` Jamal Hadi Salim [this message]
2013-12-14 5:15 ` David Miller
2013-12-14 12:22 ` Jamal Hadi Salim
2013-12-15 3:26 ` David Miller
2013-12-13 23:21 ` David Miller
2013-12-13 12:05 ` Jamal Hadi Salim
2013-12-13 18:38 ` Cong Wang
2013-12-13 21:29 ` Jamal Hadi Salim
2013-12-13 5:47 ` [PATCH net-next v3 2/6] net_sched: act: use standard struct list_head Cong Wang
2013-12-13 12:08 ` Jamal Hadi Salim
2013-12-13 18:48 ` Cong Wang
2013-12-13 21:29 ` Jamal Hadi Salim
2013-12-13 21:35 ` Cong Wang
2013-12-13 5:47 ` [PATCH net-next v3 3/6] net_sched: mirred: remove action when the target device is gone Cong Wang
2013-12-13 12:07 ` Jamal Hadi Salim
2013-12-13 12:12 ` David Laight
2013-12-13 18:52 ` Cong Wang
2013-12-13 5:47 ` [PATCH net-next v3 4/6] net_sched: cls: refactor out struct tcf_ext_map Cong Wang
2013-12-13 5:47 ` [PATCH net-next v3 5/6] net_sched: init struct tcf_hashinfo at register time Cong Wang
2013-12-13 5:47 ` [PATCH net-next v3 6/6] net_sched: convert tcf_hashinfo to hlist and use rcu Cong Wang
2013-12-13 6:48 ` Eric Dumazet
2013-12-13 21:44 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ABC975.2070308@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=David.Laight@aculab$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox