public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@parallels•com>
To: Helmut Schaa <helmut.schaa@googlemail•com>,
	"Eric W. Biederman" <ebiederm@xmission•com>
Cc: Stephen Hemminger <stephen@networkplumber•org>,
	netdev <netdev@vger•kernel.org>
Subject: Re: Fw: [Bug 66691] New: iproute2: macvlan: Wrong root device shown if in different netns
Date: Mon, 16 Dec 2013 15:01:33 +0400	[thread overview]
Message-ID: <52AEDD8D.4040907@parallels.com> (raw)
In-Reply-To: <CAGXE3d9hS4CBKTiKpn=_K3U6NPE+WzR4oFD1D3YtFb2NqzcxsA@mail.gmail.com>

On 12/16/2013 02:47 PM, Helmut Schaa wrote:
> On Mon, Dec 16, 2013 at 11:41 AM, Pavel Emelyanov <xemul@parallels•com> wrote:
>> On 12/16/2013 02:38 PM, Helmut Schaa wrote:
>>> On Fri, Dec 6, 2013 at 9:05 PM, Stephen Hemminger
>>> <stephen@networkplumber•org> wrote:
>>>> This isn't a iproute2 bug, it is only reporting what the kernel tells it
>>>
>>> But iproute2 assumes that the ifindex is unique within all net
>>> namespaces. This isn't true anymore
>>> after commit aa79e66eee5d525e2fcbd2a5fcb87ae3dd4aa9e9 "net: Make
>>> ifindex generation
>>> per-net namespace".
>>>
>>> However, in order to do the right thing iproute2 would have to know
>>> the ifindex of the
>>> link device _and_ its associated netns.
>>>
>>> Not sure how to deal with that ...
>>
>> Helmut, what would you expect to see from "ip netns exec myns ip link"
>> in case there were no device with ifindex 2 in the myns netns?
> 
> No idea, maybe something like "mac0@unknown" would be enough to express
> that the link dev is not available within this netns.

Actually, I think the problem is deeper. For example, we have a veth device
driver, the devices of that kind always exist in pairs, and one device typically
sits in one namespaces, while the other device -- in another namespace.

Right now, given one veth device, there's no way to find out where its peer is.
This creates certain difficulties for the checkpoint-restore project (CRIU)
I'm working on.

Let me add Eric in a loop to ask for his thoughts about the issue.

> My point was that it is confusing to show a clearly wrong link device.

I totally agree.

> Helmut

Thanks,
Pavel

      reply	other threads:[~2013-12-16 11:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 20:05 Fw: [Bug 66691] New: iproute2: macvlan: Wrong root device shown if in different netns Stephen Hemminger
     [not found] ` <CAGXs5wXC+eTZD3sXD4zFtkpY8tcU14Kr6AiA9=kugHups_KCHA@mail.gmail.com>
2013-12-07  9:18   ` Kevin Wilson
2013-12-09  8:02     ` Michal Kubecek
2013-12-16 10:38 ` Helmut Schaa
2013-12-16 10:41   ` Pavel Emelyanov
2013-12-16 10:47     ` Helmut Schaa
2013-12-16 11:01       ` Pavel Emelyanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AEDD8D.4040907@parallels.com \
    --to=xemul@parallels$(echo .)com \
    --cc=ebiederm@xmission$(echo .)com \
    --cc=helmut.schaa@googlemail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox