Subject: Re: [PATCH net-next V1 10/11] net/mlx4_en: Fix Supported/Advertised link mode reported by ethtool

From: Amir Vadai <[email-masked]>
Date: Tue, 17 Dec 2013 19:35:45 +0200

On 17/12/2013 17:46, Ben Hutchings wrote:
>> +		ADVERTISED_40000baseLR4_Full;
> [...]
> 
> How is this correct?  You should report the actual capabilities of the
> MAC and PHY are present, not the union of all possible modes of all the
> supported boards.
I miss-understood this field.
Will fix it.

> 
> (And the Kconfig description for MLX4_EN says '10Gbit Ethernet support',
> so if this driver now supports some 40G boards that should be updated.)
Will fix it for V2

> Ben

Thanks,
Amir