From: Wang Weidong <wangweidong1@huawei•com>
To: David Miller <davem@davemloft•net>,
Vlad Yasevich <vyasevich@gmail•com>,
Neil Horman <nhorman@tuxdriver•com>
Cc: <netdev@vger•kernel.org>, <linux-sctp@vger•kernel.org>
Subject: [PATCH net-next 2/3] sctp: remove the never used 'return' and, redundant 'break'
Date: Wed, 18 Dec 2013 17:20:32 +0800 [thread overview]
Message-ID: <52B168E0.1060108@huawei.com> (raw)
In switch() had do return, and never use the 'return NULL'. The
'break' after return or goto has no effect. Remove it.
Signed-off-by: Wang Weidong <wangweidong1@huawei•com>
---
net/sctp/input.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/net/sctp/input.c b/net/sctp/input.c
index 2a192a7..c956dc9 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -1120,15 +1120,10 @@ static struct sctp_association *__sctp_rcv_lookup_harder(struct net *net,
case SCTP_CID_INIT:
case SCTP_CID_INIT_ACK:
return __sctp_rcv_init_lookup(net, skb, laddr, transportp);
- break;
default:
return __sctp_rcv_walk_lookup(net, skb, laddr, transportp);
- break;
}
-
-
- return NULL;
}
/* Lookup an association for an inbound skb. */
--
1.7.12
next reply other threads:[~2013-12-18 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 9:20 Wang Weidong [this message]
2013-12-18 9:38 ` [PATCH net-next 2/3] sctp: remove the never used 'return' and, redundant 'break' Wang Weidong
2013-12-18 14:06 ` Neil Horman
2013-12-18 14:33 ` Wang Weidong
2013-12-19 2:02 ` [PATCH net-next v2] sctp: remove the never used 'return' and " Wang Weidong
2013-12-19 12:12 ` Neil Horman
2013-12-22 23:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B168E0.1060108@huawei.com \
--to=wangweidong1@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox