From: Ding Tianhong <dingtianhong@huawei•com>
To: Joe Perches <joe@perches•com>
Cc: Ding Tianhong <dthxman@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next v2 0/6] slight optimization of addr compare for some modules
Date: Wed, 18 Dec 2013 18:06:35 +0800 [thread overview]
Message-ID: <52B173AB.6020901@huawei.com> (raw)
In-Reply-To: <1387358236.13593.36.camel@joe-AO722>
On 2013/12/18 17:17, Joe Perches wrote:
> On Wed, 2013-12-18 at 16:47 +0800, Ding Tianhong wrote:
>> On 2013/12/17 9:58, Ding Tianhong wrote:
>>> On 2013/12/17 1:25, Joe Perches wrote:
>>>> These should still be inspected for appropriate use of
>>>> ether_addr_equal or ether_addr_equal_unaligned, but a
>>>> better cocci input sp-file is:
>>>>
>>>> $ cat ether_addr_equal_unaligned.cocci
>>>> @@
>>>> expression e1;
>>>> expression e2;
>>>> @@
> []
>> There are too many places need to be changed, should I make it in one patch or several pathset,
>> pls give me some advise. thanks
>
> Separate per-maintainer patches are generally good.
> It can take several attempts to get these applied
> in all the various trees.
>
> So maybe 1 patch for each of most of these. Maybe
> some of these like drivers/media, drivers/mtd and
> drivers/staging could probably be single patches.
>
Hi Joe:
I found there is a bug in spatch, it could not deal with
- memcmp(e1, e2, \(6\|ETH_ALEN\)) != 0
+ !ether_addr_equal_unaligned(e1, e2)
diff -u -p a/caif/cfrfml.c b/caif/cfrfml.c
--- a/caif/cfrfml.c
+++ b/caif/cfrfml.c
@@ -79,7 +79,7 @@ static struct cfpkt *rfm_append(struct c
return NULL;
/* Verify correct header */
- if (memcmp(seghead, rfml->seghead, 6) != 0)
+ if (!ether_addr_equal_unaligned(seghead, rfml->seghead) != 0)
return NULL;
tmppkt = cfpkt_append(rfml->incomplete_frm, pkt,
Regards
Ding
>
next prev parent reply other threads:[~2013-12-18 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 8:24 [PATCH net-next v2 0/6] slight optimization of addr compare for some modules Ding Tianhong
2013-12-16 14:45 ` Joe Perches
2013-12-16 14:53 ` Ding Tianhong
2013-12-16 15:16 ` Joe Perches
2013-12-16 17:25 ` Joe Perches
2013-12-17 1:58 ` Ding Tianhong
2013-12-18 8:47 ` Ding Tianhong
2013-12-18 9:17 ` Joe Perches
2013-12-18 9:35 ` Ding Tianhong
2013-12-18 10:06 ` Ding Tianhong [this message]
2013-12-18 16:51 ` Joe Perches
2013-12-19 1:24 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B173AB.6020901@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dthxman@gmail$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox