Subject: Re: [Patch net-next 1/4] net_sched: act: clean up notification functions

From: Jamal Hadi Salim <[email-masked]>
Date: Thu, 19 Dec 2013 09:40:32 -0500

On 12/18/13 19:48, Cong Wang wrote:
> On Wed, Dec 18, 2013 at 4:36 PM, Cong Wang <[email-masked]> wrote:
>> -               if (ret > 0)
>> -                       return 0;
>> -               return ret;
>> -       }
>> +       else /* delete */
>> +               ret = tcf_del_notify(net, n, &actions, portid);
>
> This piece doesn't look correct. :-) I will fix it.
>

It is not as trivial and i dont think you have the correct tests to
vet it.
Please give me until this weekend to test your other changes
that are already in.
I also had some changes i wanted to get in. Then I will review
and maybe test this as well...

cheers,
jamal