Subject: Re: [PATCH net-next 1/3] bonding: add option lp_interval for loading module

From: Sergei Shtylyov <[email-masked]>
Date: Fri, 20 Dec 2013 17:42:43 +0400

Hello.

On 20-12-2013 9:10, Ding Tianhong wrote:

> The bond driver could set the lp_interval when loading module.

> Signed-off-by: Ding Tianhong <[email-masked]>
> ---
>   drivers/net/bonding/bond_main.c | 15 +++++++++++++--
>   1 file changed, 13 insertions(+), 2 deletions(-)

> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index c0456cc..368f7e4 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
[...]
> @@ -4271,6 +4276,12 @@ static int bond_check_params(struct bond_params *params)
>   		fail_over_mac_value = BOND_FOM_NONE;
>   	}
>
> +	if (lp_interval == 0) {
> +		pr_warning("Warning: ip_interval must be between 1 and %d, so it was reset to %d\n",
> +			INT_MAX, BOND_ALB_DEFAULT_LP_INTERVAL);

    The continuation line should be aligned under ", according to the 
networking coding style.

WBR, Sergei