From: Valentina Giusti <valentina.giusti@bmw-carit•de>
To: Florian Westphal <fw@strlen•de>
Cc: <netfilter-devel@vger•kernel.org>, <netdev@vger•kernel.org>,
<jpa@google•com>, <pablo@netfilter•org>,
<daniel.wagner@bmw-carit•de>
Subject: Re: [PATCH v3 1/2] netfilter_queue: enable UID/GID socket info retrieval
Date: Fri, 20 Dec 2013 16:10:18 +0100 [thread overview]
Message-ID: <52B45DDA.5050504@bmw-carit.de> (raw)
In-Reply-To: <20131220150324.GB29632@breakpoint.cc>
On 12/20/2013 04:03 PM, Florian Westphal wrote:
> Valentina Giusti <valentina.giusti@bmw-carit•de> wrote:
>>> I think this should be 'return 0'?
>> I put return -1 because I think that if userspace has requested to
>> receive UID and GID, then it should be dumped only packets that have
>> that information available.
>> Are you suggesting that it should be otherwise?
>
> Yes, doing that doesn't make sense to me.
> And it is inconsitent:
> Packets without socket information are queued normally
> in your patch, but suddently if its a timewait socket
> its an error?
>
> Why would we want timewait packets to NOT be queued?
> vs. for example forwarded packets?
>
> Userspace can test for presence of the attributes, i.e.
> no NFQA_UID attribute -> no socket present, or lack of uid
> information.
>
> If you have a counter-example?
>
Sorry no, I think you are right, thanks for the explanation. Should I
resend the patch or is it a change small enough that can be done when
applied? Unless there are still other comments, ofc.
Thanks,
- Val
next prev parent reply other threads:[~2013-12-20 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 12:33 [PATCH v3 0/2] Add UID/GID info to NFQUEUE valentina.giusti
2013-12-20 12:33 ` [PATCH v3 1/2] netfilter_queue: enable UID/GID socket info retrieval valentina.giusti
2013-12-20 14:09 ` Florian Westphal
2013-12-20 14:32 ` Valentina Giusti
2013-12-20 15:03 ` Florian Westphal
2013-12-20 15:10 ` Valentina Giusti [this message]
2013-12-20 12:33 ` [PATCH v3 2/2] libnetfilter_queue: add support for UID/GID socket info valentina.giusti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B45DDA.5050504@bmw-carit.de \
--to=valentina.giusti@bmw-carit$(echo .)de \
--cc=daniel.wagner@bmw-carit$(echo .)de \
--cc=fw@strlen$(echo .)de \
--cc=jpa@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox