Subject: Re: [PATCH net-next 2/2] netlink: specify netlink packet direction for nlmon

From: Daniel Borkmann <[email-masked]>
Date: Mon, 23 Dec 2013 01:06:24 +0100

On 12/23/2013 12:56 AM, David Miller wrote:
> From: Daniel Borkmann <[email-masked]>
> Date: Thu, 19 Dec 2013 02:29:39 +0100
>
>> @@ -29,6 +29,9 @@ struct sockaddr_ll {
>>   /* These ones are invisible by user level */
>>   #define PACKET_LOOPBACK		5		/* MC/BRD frame looped back */
>>   #define PACKET_FASTROUTE	6		/* Fastrouted frame	*/
>> +/* These ones are for nlmon devices */
>> +#define PACKET_USER		0		/* To user space */
>> +#define PACKET_KERNEL		1		/* To kernel space */
>
> I know it is tempting to do so, but please do not reuse values
> like this.

Hm, ok. As we only have 3 bits for all this, are you okay with
doing the following ...

#define PACKET_USER	6	/* To user space   */
#define PACKET_KERNEL	7	/* To kernel space */

PACKET_FASTROUTE isn't used anywhere in the tree, only defined
in this header file. Then, by doing this, we would still fit.

> THanks.