From: chenweilong <chenweilong@huawei•com>
To: Joe Perches <joe@perches•com>
Cc: <davem@davemloft•net>, <kuznet@ms2•inr.ac.ru>,
<jmorris@namei•org>, <yoshfuji@linux-ipv6•org>, <kaber@trash•net>,
<pablo@netfilter•org>, <kadlec@blackhole•kfki.hu>,
<steffen.klassert@secunet•com>, <herbert@gondor•apana.org.au>,
<netdev@vger•kernel.org>
Subject: Re: [patch net-next v2 7/7] ipv4: ERROR: do not use C99 // comments
Date: Mon, 23 Dec 2013 11:56:10 +0800 [thread overview]
Message-ID: <52B7B45A.5040805@huawei.com> (raw)
In-Reply-To: <1387767575.22671.46.camel@joe-AO722>
On 2013/12/23 10:59, Joe Perches wrote:
> On Mon, 2013-12-23 at 10:14 +0800, Chen Weilong wrote:
>> From: Weilong Chen <chenweilong@huawei•com>
> []
>> diff --git a/net/ipv4/tcp_yeah.c b/net/ipv4/tcp_yeah.c
> []
>> @@ -15,13 +15,13 @@
>>
>> #include "tcp_vegas.h"
>>
>> -#define TCP_YEAH_ALPHA 80 //lin number of packets queued at the bottleneck
>> -#define TCP_YEAH_GAMMA 1 //lin fraction of queue to be removed per rtt
>> -#define TCP_YEAH_DELTA 3 //log minimum fraction of cwnd to be removed on loss
>> -#define TCP_YEAH_EPSILON 1 //log maximum fraction to be removed on early decongestion
>> -#define TCP_YEAH_PHY 8 //lin maximum delta from base
>> -#define TCP_YEAH_RHO 16 //lin minimum number of consecutive rtt to consider competition on loss
>> -#define TCP_YEAH_ZETA 50 //lin minimum number of state switchs to reset reno_count
>> +#define TCP_YEAH_ALPHA 80 /* lin number of packets queued at the bottleneck */
>> +#define TCP_YEAH_GAMMA 1 /* lin fraction of queue to be removed per rtt */
>> +#define TCP_YEAH_DELTA 3 /* log minimum fraction of cwnd to be removed on loss */
>> +#define TCP_YEAH_EPSILON 1 /* log maximum fraction to be removed on early decongestion */
>> +#define TCP_YEAH_PHY 8 /* lin maximum delta from base */
>> +#define TCP_YEAH_RHO 16 /* lin minimum number of consecutive rtt to consider competition on loss */
>> +#define TCP_YEAH_ZETA 50 /* lin minimum number of state switchs to reset reno_count */
>
> Does anyone actually use this?
> Does "lin" add anything useful?
> lin should probably be removed otherwise.
> What does it mean anyway? link? linear?
>
> The link to the paper in the file is dead.
> http://wil.cs.caltech.edu/pfldnet2007/paper/YeAH_TCP.pdf
>
> archive.org has it at:
> https://web.archive.org/web/20080316215752/http://wil.cs.caltech.edu/pfldnet2007/paper/YeAH_TCP.pdf
>
> btw, spelling: s/switchs/switches/
>
>
> .
>
Thanks for pointing out shortcomings in my patch,I'll fix it.
I agree with you that 'lin' can be removed.
I think 'lin' means 'socket link', according to the code,they are used for 'struct yeah',that is placed in
each 'struct sock'.
next prev parent reply other threads:[~2013-12-23 3:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 2:14 [patch net-next v2 0/7] fix checkpatch errors Chen Weilong
2013-12-23 2:14 ` [patch net-next v2 1/7] ipv4: do clean up with spaces Chen Weilong
2013-12-23 2:14 ` [patch net-next v2 3/7] ipv4: fix checkpatch error with foo * bar Chen Weilong
2013-12-23 2:14 ` [patch net-next v2 4/7] ipv4: fix all space errors in file igmp.c Chen Weilong
2013-12-23 2:14 ` [patch net-next v2 5/7] ipv4: ERROR: do not initialise globals to 0 or NULL Chen Weilong
2013-12-23 2:14 ` [patch net-next v2 6/7] ipv4: ERROR: code indent should use tabs where possible Chen Weilong
2013-12-23 2:14 ` [patch net-next v2 7/7] ipv4: ERROR: do not use C99 // comments Chen Weilong
2013-12-23 2:59 ` Joe Perches
2013-12-23 3:56 ` chenweilong [this message]
2013-12-26 18:44 ` [patch net-next v2 0/7] fix checkpatch errors David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B7B45A.5040805@huawei.com \
--to=chenweilong@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jmorris@namei$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=kadlec@blackhole$(echo .)kfki.hu \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox