Subject: Re: [PATCH 09/21] batman-adv: slight optimization of addr compare

From: Antonio Quartulli <[email-masked]>
Date: Mon, 23 Dec 2013 09:46:11 +0100

On 23/12/13 06:10, Ding Tianhong wrote:

[...]

> --- a/net/batman-adv/originator.c
> +++ b/net/batman-adv/originator.c
> @@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, const void *data2)
>  	const void *data1 = container_of(node, struct batadv_orig_node,
>  					 hash_entry);
>  
> -	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
> +	return ether_addr_equal_unaligned(data1, data2) ? 1 : 0;

ether_addr_equal_unaligned() returns a bool value which is implicitly
converted to 1 or 0: there is no need for the ternary if anymore.

>  }
>  
>  /**
> diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
> index 4add57d..5e66d4b 100644
> --- a/net/batman-adv/translation-table.c
> +++ b/net/batman-adv/translation-table.c
> @@ -51,7 +51,7 @@ static int batadv_compare_tt(const struct hlist_node *node, const void *data2)
>  	const void *data1 = container_of(node, struct batadv_tt_common_entry,
>  					 hash_entry);
>  
> -	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
> +	return ether_addr_equal_unaligned(data1, data2) ? 1 : 0;

same here

Moreover, include linux/etherdevice.h in both files as explained in
point 1) of Documentation/SubmitChecklist

Thanks.

Cheers,

-- 
Antonio Quartulli