From: Ding Tianhong <dingtianhong@huawei•com>
To: Antonio Quartulli <antonio@meshcoding•com>,
Joe Perches <joe@perches•com>
Cc: Marek Lindner <mareklindner@neomailbox•ch>,
Simon Wunderlich <sw@simonwunderlich•de>,
"David S. Miller" <davem@davemloft•net>,
<b.a.t.m.a.n@lists•open-mesh.org>,
Netdev <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH 09/21] batman-adv: slight optimization of addr compare
Date: Mon, 23 Dec 2013 17:12:36 +0800 [thread overview]
Message-ID: <52B7FE84.4030302@huawei.com> (raw)
In-Reply-To: <52B7FD01.9080006@meshcoding.com>
On 2013/12/23 17:06, Antonio Quartulli wrote:
> On 23/12/13 09:59, Joe Perches wrote:
>> On Mon, 2013-12-23 at 09:46 +0100, Antonio Quartulli wrote:
>>> On 23/12/13 06:10, Ding Tianhong wrote:
>>>
>>> [...]
>>>
>>>> --- a/net/batman-adv/originator.c
>>>> +++ b/net/batman-adv/originator.c
>>>> @@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, const void *data2)
>>>> const void *data1 = container_of(node, struct batadv_orig_node,
>>>> hash_entry);
>>>>
>>>> - return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
>>>> + return ether_addr_equal_unaligned(data1, data2) ? 1 : 0;
>>>
>>> ether_addr_equal_unaligned() returns a bool value which is implicitly
>>> converted to 1 or 0: there is no need for the ternary if anymore.
>>
>> Should these use batadv_compare_eth?
>>
>
> That makes sense.
>
> I was wondering whether we should get rid of batadv_compare_eth() at all
> and always use ether_addr_equal_unaligned(). The "unaligned explanation"
> is part of the name, so there is no need to use a commented helper anymore.
>
> However, until that moment it is better to get stuck to
> batadv_compare_eth().
>
>
> Ding, can you also follow Joe's suggestion for this patch please?
>
>
> Thanks,
>
>
Ok
next prev parent reply other threads:[~2013-12-23 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 5:10 [PATCH 09/21] batman-adv: slight optimization of addr compare Ding Tianhong
2013-12-23 8:46 ` Antonio Quartulli
2013-12-23 8:59 ` Joe Perches
2013-12-23 9:06 ` Antonio Quartulli
2013-12-23 9:12 ` Ding Tianhong [this message]
2013-12-23 9:10 ` Ding Tianhong
2013-12-23 9:09 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B7FE84.4030302@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=antonio@meshcoding$(echo .)com \
--cc=b.a.t.m.a.n@lists$(echo .)open-mesh.org \
--cc=davem@davemloft$(echo .)net \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mareklindner@neomailbox$(echo .)ch \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sw@simonwunderlich$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox