From: Wang Weidong <wangweidong1@huawei•com>
To: Ying Xue <ying.xue@windriver•com>,
"Stephens, Allan" <allan.stephens@windriver•com>,
<jon.maloy@ericsson•com>, <davem@davemloft•net>
Cc: <David.Laight@ACULAB•COM>, <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next v2 1/2] tipc: make the code look more better
Date: Wed, 25 Dec 2013 10:52:53 +0800 [thread overview]
Message-ID: <52BA4885.8080900@huawei.com> (raw)
In-Reply-To: <52BA4622.3060702@windriver.com>
On 2013/12/25 10:42, Ying Xue wrote:
> On 12/25/2013 10:11 AM, Wang Weidong wrote:
>> In commit 0cee6bbe06f ("tipc: remove unnecessary variables and conditions")
>> didn't make the code look best. So fix it. This patch is cosmetic
>> and does not change the operation of TIPC in any way.
>>
>
> I cannot see what value the patch does provide.
>
> Actually the original logic seems better understandable for us because
> it immediately lets us know how to do if "tp_ptr->connected" is true.
> Instead the patch has a little negative effect on performance because
> "tp_ptr->connected" is true in most time.
>
Sure, You are right. So just ignore it.
Thanks,
Wang
> Regards,
> Ying
>
>> Suggested-by: David Laight <David.Laight@ACULAB•COM>
>> Signed-off-by: Wang Weidong <wangweidong1@huawei•com>
>> ---
>> net/tipc/port.c | 13 ++++++-------
>> 1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/net/tipc/port.c b/net/tipc/port.c
>> index 5fd4c8c..ee81be0 100644
>> --- a/net/tipc/port.c
>> +++ b/net/tipc/port.c
>> @@ -832,14 +832,13 @@ exit:
>> */
>> int __tipc_disconnect(struct tipc_port *tp_ptr)
>> {
>> - if (tp_ptr->connected) {
>> - tp_ptr->connected = 0;
>> - /* let timer expire on it's own to avoid deadlock! */
>> - tipc_nodesub_unsubscribe(&tp_ptr->subscription);
>> - return 0;
>> - }
>> + if (!tp_ptr->connected)
>> + return -ENOTCONN;
>>
>> - return -ENOTCONN;
>> + tp_ptr->connected = 0;
>> + /* let timer expire on it's own to avoid deadlock! */
>> + tipc_nodesub_unsubscribe(&tp_ptr->subscription);
>> + return 0;
>> }
>>
>> /*
>>
>
>
> .
>
next prev parent reply other threads:[~2013-12-25 2:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 2:11 [PATCH net-next v2 0/2] tipc: do some fixups Wang Weidong
2013-12-25 2:11 ` [PATCH net-next v2 1/2] tipc: make the code look more better Wang Weidong
2013-12-25 2:42 ` Ying Xue
2013-12-25 2:52 ` Wang Weidong [this message]
2013-12-25 2:11 ` [PATCH net-next v2 2/2] tipc: make the code look more readability Wang Weidong
2013-12-25 10:47 ` Sergei Shtylyov
2013-12-25 12:27 ` Wang Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BA4885.8080900@huawei.com \
--to=wangweidong1@huawei$(echo .)com \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=allan.stephens@windriver$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jon.maloy@ericsson$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox