From: Duan Jiong <duanj.fnst@cn•fujitsu.com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next] bridge: remove extern from function prototypes
Date: Thu, 26 Dec 2013 14:39:23 +0800 [thread overview]
Message-ID: <52BBCF1B.1010901@cn.fujitsu.com> (raw)
In-Reply-To: <52BBCA57.9080706@cn.fujitsu.com>
I'm so sorry, there is something wrong with it,
please just ignore this patch!
于 2013年12月26日 14:19, Duan Jiong 写道:
>
> There are a mix of function prototypes with and without extern
> in the kernel sources. Standardize on not using extern for
> function prototypes.
>
> Function prototypes don't need to be written with extern.
> extern is assumed by the compiler. Its use is as unnecessary as
> using auto to declare automatic/local variables in a block.
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn•fujitsu.com>
> ---
> net/bridge/br_private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 2e77d92..458889e 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -762,7 +762,7 @@ unsigned long br_timer_value(const struct timer_list *timer);
>
> /* br.c */
> #if IS_ENABLED(CONFIG_ATM_LANE)
> -extern int (*br_fdb_test_addr_hook)(struct net_device *dev, unsigned char *addr);
> +int (*br_fdb_test_addr_hook)(struct net_device *dev, unsigned char *addr);
> #endif
>
> /* br_netlink.c */
>
next prev parent reply other threads:[~2013-12-26 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 6:19 [PATCH net-next] bridge: remove extern from function prototypes Duan Jiong
2013-12-26 6:39 ` Duan Jiong [this message]
2013-12-26 11:26 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BBCF1B.1010901@cn.fujitsu.com \
--to=duanj.fnst@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox