Subject: Re: [PATCH] sh_eth: coding style fixes

From: Sergei Shtylyov <[email-masked]>
Date: Fri, 03 Jan 2014 13:50:29 +0400

Hello.

On 03-01-2014 4:34, David Miller wrote:

>> @@ -1952,8 +1949,8 @@ static void sh_eth_tx_timeout(struct net
>>   	netif_stop_queue(ndev);
>>
>>   	if (netif_msg_timer(mdp))
>> -		dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x,"
>> -	       " resetting...\n", ndev->name, (int)sh_eth_read(ndev, EESR));
>> +		dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x, resetting...\n"
>> +			ndev->name, (int)sh_eth_read(ndev, EESR));
>>
>>   	/* tx_errors count up */
>>   	ndev->stats.tx_errors++;

> You did not build test this.

    Hm, I was sure I did but you're right...

> drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_tx_timeout’:
> drivers/net/ethernet/renesas/sh_eth.c:1953:4: error: expected ‘)’ before ‘ndev’
> drivers/net/ethernet/renesas/sh_eth.c:1953:4: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat]
> drivers/net/ethernet/renesas/sh_eth.c:1953:4: warning: format ‘%x’ expects a matching ‘unsigned int’ argument [-Wformat]

    Missing comma, apparently. :-(

WBR, Sergei