Subject: Re: [PATCH net 2/2] net: core: explicitly select a txq before doing l2 forwarding

From: John Fastabend <[email-masked]>
Date: Tue, 07 Jan 2014 00:37:31 -0800

[...]

>>
>> +int dfwd_direct_xmit(struct sk_buff *skb, struct net_device *dev,
>> +             void *accel_priv)
>> +{
>> +    struct netdev_queue *txq;
>> +    int ret = NETDEV_TX_BUSY;
>> +    int index;
>> +
>> +    BUG_ON(!dev->netdev_ops->ndo_dfwd_select_queue);
>> +    index =    dev->netdev_ops->ndo_dfwd_select_queue(dev, skb,
>> +                               accel_priv);
>> +
>> +    local_bh_disable();
>> +
>> +    skb_set_queue_mapping(skb, index);
>
> How about replacing the index calculation and skb_set_queue_mapping with
> netdev_pick_tx(). Then we don't need to add a new op and the existing
> XPS, tx hash and select_queue() op works.
>

Sorry for the noise that was dumb it wouldn't work.